[PATCH v2 0/4] nvmem: layouts: Create a macro to register drivers

Miquel Raynal posted 4 patches 2 years, 10 months ago
drivers/nvmem/layouts/onie-tlv.c | 15 +--------------
drivers/nvmem/layouts/sl28vpd.c  | 14 +-------------
include/linux/nvmem-provider.h   |  6 ++++++
3 files changed, 8 insertions(+), 27 deletions(-)
[PATCH v2 0/4] nvmem: layouts: Create a macro to register drivers
Posted by Miquel Raynal 2 years, 10 months ago
Hello Srinivas,

Following your former review, here are a few changes creating and using
a macro to simplify nvmem layout driver registration.

While doing that I figured out the MODULE_ALIAS() macro in the Onie TLV
driver was useless and wrong, so there is a patch to drop it, but if you
wish you can also squash it with:
"nvmem: layouts: onie-tlv: Add new layout driver".

Thanks!
Miquèl

Changes in v2:
* First patch now includes driver.h as reported by Rafal.

Miquel Raynal (4):
  nvmem: Add macro to register nvmem layout drivers
  nvmem: layouts: sl28vpd: Use module_nvmem_layout_driver()
  nvmem: layouts: onie-tlv: Use module_nvmem_layout_driver()
  nvmem: layouts: onie-tlv: Drop wrong module alias

 drivers/nvmem/layouts/onie-tlv.c | 15 +--------------
 drivers/nvmem/layouts/sl28vpd.c  | 14 +-------------
 include/linux/nvmem-provider.h   |  6 ++++++
 3 files changed, 8 insertions(+), 27 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/4] nvmem: layouts: Create a macro to register drivers
Posted by Srinivas Kandagatla 2 years, 10 months ago

On 22/03/2023 16:58, Miquel Raynal wrote:
> Hello Srinivas,
> 
> Following your former review, here are a few changes creating and using
> a macro to simplify nvmem layout driver registration.
> 
> While doing that I figured out the MODULE_ALIAS() macro in the Onie TLV
> driver was useless and wrong, so there is a patch to drop it, but if you
> wish you can also squash it with:
> "nvmem: layouts: onie-tlv: Add new layout driver".
> 
> Thanks!
> Miquèl
> 
> Changes in v2:
> * First patch now includes driver.h as reported by Rafal.
> 
> Miquel Raynal (4):
>    nvmem: Add macro to register nvmem layout drivers
>    nvmem: layouts: sl28vpd: Use module_nvmem_layout_driver()
>    nvmem: layouts: onie-tlv: Use module_nvmem_layout_driver()
>    nvmem: layouts: onie-tlv: Drop wrong module alias

Applied thanks,

--srini

> 
>   drivers/nvmem/layouts/onie-tlv.c | 15 +--------------
>   drivers/nvmem/layouts/sl28vpd.c  | 14 +-------------
>   include/linux/nvmem-provider.h   |  6 ++++++
>   3 files changed, 8 insertions(+), 27 deletions(-)
>