[PATCH v4] staging: greybus: remove unnecessary blank line

Menna Mahmoud posted 1 patch 2 years, 10 months ago
drivers/staging/greybus/greybus_authentication.h | 1 -
drivers/staging/greybus/pwm.c                    | 1 -
2 files changed, 2 deletions(-)
[PATCH v4] staging: greybus: remove unnecessary blank line
Posted by Menna Mahmoud 2 years, 10 months ago
Remove unnecessary blank line before struct as reported
by checkpatch:

" CHECK: Please don't use multiple blank lines "

Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
---
change in v4:
        add version of the patch.
change in v3:
        add patches that have same edit in sigle commit.
change in v2:
        add patches that have same edit in sigle patch.
---
 drivers/staging/greybus/greybus_authentication.h | 1 -
 drivers/staging/greybus/pwm.c                    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
index 7edc7295b7ab..48b4a9794d3c 100644
--- a/drivers/staging/greybus/greybus_authentication.h
+++ b/drivers/staging/greybus/greybus_authentication.h
@@ -41,7 +41,6 @@
 #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
 #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
 
-
 /* IOCTL support */
 struct cap_ioc_get_endpoint_uid {
 	__u8			uid[8];
diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
index 3fda172239d2..26d39e08c3b6 100644
--- a/drivers/staging/greybus/pwm.c
+++ b/drivers/staging/greybus/pwm.c
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
 #define pwm_chip_to_gb_pwm_chip(chip) \
 	container_of(chip, struct gb_pwm_chip, chip)
 
-
 static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
 {
 	struct gb_pwm_count_response response;
-- 
2.34.1
Re: [PATCH v4] staging: greybus: remove unnecessary blank line
Posted by Uwe Kleine-König 2 years, 10 months ago
On Wed, Mar 22, 2023 at 01:37:34PM +0200, Menna Mahmoud wrote:
> Remove unnecessary blank line before struct as reported
> by checkpatch:
> 
> " CHECK: Please don't use multiple blank lines "
> 
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>

Looks good to me now. Thanks for not giving up.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |