Bluetooth: NXP: select CONFIG_CRC8

[PATCH] Bluetooth: NXP: select CONFIG_CRC8

Posted by Arnd Bergmann 2 years, 10 months ago

From: Arnd Bergmann <arnd@arndb.de>

The driver needs both CRC32 and CRC8 to link correctly:

ld.lld: error: undefined symbol: crc8_populate_msb
>>> referenced by btnxpuart.c
>>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
ld.lld: error: undefined symbol: crc8
>>> referenced by btnxpuart.c
>>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a

Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/bluetooth/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 0703bdd44140..f84322d375de 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -469,6 +469,7 @@ config BT_NXPUART
 	tristate "NXP protocol support"
 	depends on SERIAL_DEV_BUS
 	select CRC32
+	select CRC8
 	help
 	  NXP is serial driver required for NXP Bluetooth
 	  devices with UART interface.
-- 
2.39.2

Re: [PATCH] Bluetooth: NXP: select CONFIG_CRC8

Posted by patchwork-bot+bluetooth@kernel.org 2 years, 10 months ago

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 22 Mar 2023 12:16:27 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver needs both CRC32 and CRC8 to link correctly:
> 
> ld.lld: error: undefined symbol: crc8_populate_msb
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: crc8
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
> 
> [...]

Here is the summary with links:
  - Bluetooth: NXP: select CONFIG_CRC8
    https://git.kernel.org/bluetooth/bluetooth-next/c/335aed70654a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] Bluetooth: NXP: select CONFIG_CRC8

Posted by Ilpo Järvinen 2 years, 10 months ago

On Wed, 22 Mar 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver needs both CRC32 and CRC8 to link correctly:
> 
> ld.lld: error: undefined symbol: crc8_populate_msb
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: crc8
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
> 
> Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 0703bdd44140..f84322d375de 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -469,6 +469,7 @@ config BT_NXPUART
>  	tristate "NXP protocol support"
>  	depends on SERIAL_DEV_BUS
>  	select CRC32
> +	select CRC8
>  	help
>  	  NXP is serial driver required for NXP Bluetooth
>  	  devices with UART interface.
> 

Right. ...I should have realized this was missing too when I noticed 
select CRC32 wasn't there.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.