[PATCH 7/8] ext4: remove ext4_block_group and ext4_block_group_offset declaration

Kemeng Shi posted 8 patches 3 years ago
[PATCH 7/8] ext4: remove ext4_block_group and ext4_block_group_offset declaration
Posted by Kemeng Shi 3 years ago
For ext4_block_group and ext4_block_group_offset, there are only
declaration without definition. Just remove them.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/ext4.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 9b2cfc32cf78..f25f13a357de 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2697,10 +2697,6 @@ extern void ext4_get_group_no_and_offset(struct super_block *sb,
 extern ext4_group_t ext4_get_group_number(struct super_block *sb,
 					  ext4_fsblk_t block);
 
-extern unsigned int ext4_block_group(struct super_block *sb,
-			ext4_fsblk_t blocknr);
-extern ext4_grpblk_t ext4_block_group_offset(struct super_block *sb,
-			ext4_fsblk_t blocknr);
 extern int ext4_bg_has_super(struct super_block *sb, ext4_group_t group);
 extern unsigned long ext4_bg_num_gdb(struct super_block *sb,
 			ext4_group_t group);
-- 
2.30.0
Re: [PATCH 7/8] ext4: remove ext4_block_group and ext4_block_group_offset declaration
Posted by Ojaswin Mujoo 3 years ago
On Wed, Mar 22, 2023 at 12:12:19AM +0800, Kemeng Shi wrote:
> For ext4_block_group and ext4_block_group_offset, there are only
> declaration without definition. Just remove them.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Feel free to add:

Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>

Regards,
ojaswin

> ---
>  fs/ext4/ext4.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 9b2cfc32cf78..f25f13a357de 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2697,10 +2697,6 @@ extern void ext4_get_group_no_and_offset(struct super_block *sb,
>  extern ext4_group_t ext4_get_group_number(struct super_block *sb,
>  					  ext4_fsblk_t block);
>  
> -extern unsigned int ext4_block_group(struct super_block *sb,
> -			ext4_fsblk_t blocknr);
> -extern ext4_grpblk_t ext4_block_group_offset(struct super_block *sb,
> -			ext4_fsblk_t blocknr);
>  extern int ext4_bg_has_super(struct super_block *sb, ext4_group_t group);
>  extern unsigned long ext4_bg_num_gdb(struct super_block *sb,
>  			ext4_group_t group);
> -- 
> 2.30.0
>