[PATCH 1/3] dt-bindings: arm: ti: k3: Add compatible for AM62x LP SK

Vignesh Raghavendra posted 3 patches 2 years, 10 months ago
There is a newer version of this series
[PATCH 1/3] dt-bindings: arm: ti: k3: Add compatible for AM62x LP SK
Posted by Vignesh Raghavendra 2 years, 10 months ago
Add compatible for AM62x SoC based Low Power Starter Kit board[1]

[1] https://www.ti.com/tool/SK-AM62-LP

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index a60a4065caa8..56fdd94bf899 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -29,6 +29,7 @@ properties:
         items:
           - enum:
               - ti,am625-sk
+              - ti,am62x-lp-sk
           - const: ti,am625
 
       - description: K3 AM642 SoC
-- 
2.40.0
Re: [PATCH 1/3] dt-bindings: arm: ti: k3: Add compatible for AM62x LP SK
Posted by Krzysztof Kozlowski 2 years, 10 months ago
On 20/03/2023 06:13, Vignesh Raghavendra wrote:
> Add compatible for AM62x SoC based Low Power Starter Kit board[1]
> 
> [1] https://www.ti.com/tool/SK-AM62-LP
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index a60a4065caa8..56fdd94bf899 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -29,6 +29,7 @@ properties:
>          items:
>            - enum:
>                - ti,am625-sk
> +              - ti,am62x-lp-sk

Don't use wildcards in compatibles... but judging by
https://www.ti.com/tool/SK-AM62 it looks like model name. If it is truly
model name, not wildcard, then:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH 1/3] dt-bindings: arm: ti: k3: Add compatible for AM62x LP SK
Posted by Vignesh Raghavendra 2 years, 10 months ago

On 20/03/23 20:50, Krzysztof Kozlowski wrote:
> On 20/03/2023 06:13, Vignesh Raghavendra wrote:
>> Add compatible for AM62x SoC based Low Power Starter Kit board[1]
>>
>> [1] https://www.ti.com/tool/SK-AM62-LP
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> ---
>>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> index a60a4065caa8..56fdd94bf899 100644
>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> @@ -29,6 +29,7 @@ properties:
>>          items:
>>            - enum:
>>                - ti,am625-sk
>> +              - ti,am62x-lp-sk
> 
> Don't use wildcards in compatibles... but judging by
> https://www.ti.com/tool/SK-AM62 it looks like model name. If it is truly
> model name, not wildcard, then:

I used the name on the EVM's silk screen. But I think its better to drop
the wildcard. Will respin with that fixed.

FWIW Correct URL is https://www.ti.com/tool/SK-AM62-LP (Boards look very
identical though ;) )

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Thanks

-- 
Regards
Vignesh