[PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function

Lizhe posted 1 patch 1 year, 3 months ago
drivers/s390/crypto/vfio_ap_drv.c | 6 ------
1 file changed, 6 deletions(-)
[PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
Posted by Lizhe 1 year, 3 months ago
If there is no driver match function, the driver core assumes that each
candidate pair (driver, device) matches, see driver_match_device().

Drop the matrix bus's match function that always returned 1 and so 
implements the same behaviour as when there is no match function

Signed-off-by: Lizhe <sensor1010@163.com>
---
 drivers/s390/crypto/vfio_ap_drv.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 997b524bdd2b..9341c000da41 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -59,14 +59,8 @@ static void vfio_ap_matrix_dev_release(struct device *dev)
 	kfree(matrix_dev);
 }
 
-static int matrix_bus_match(struct device *dev, struct device_driver *drv)
-{
-	return 1;
-}
-
 static struct bus_type matrix_bus = {
 	.name = "matrix",
-	.match = &matrix_bus_match,
 };
 
 static struct device_driver matrix_driver = {
-- 
2.34.1
Re: [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
Posted by Heiko Carstens 1 year, 3 months ago
On Sun, Mar 19, 2023 at 12:19:41PM +0800, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
> 
> Drop the matrix bus's match function that always returned 1 and so 
> implements the same behaviour as when there is no match function
> 
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
>  drivers/s390/crypto/vfio_ap_drv.c | 6 ------
>  1 file changed, 6 deletions(-)

Applied.
Re: [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
Posted by Anthony Krowiak 1 year, 3 months ago
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>

On 3/19/23 12:19 AM, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
>
> Drop the matrix bus's match function that always returned 1 and so
> implements the same behaviour as when there is no match function
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
>   drivers/s390/crypto/vfio_ap_drv.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 997b524bdd2b..9341c000da41 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -59,14 +59,8 @@ static void vfio_ap_matrix_dev_release(struct device *dev)
>   	kfree(matrix_dev);
>   }
>   
> -static int matrix_bus_match(struct device *dev, struct device_driver *drv)
> -{
> -	return 1;
> -}
> -
>   static struct bus_type matrix_bus = {
>   	.name = "matrix",
> -	.match = &matrix_bus_match,
>   };
>   
>   static struct device_driver matrix_driver = {