[v2 PATCH] io_uring: rsrc: Optimize return value variable 'ret'

Li zeming posted 1 patch 2 years, 10 months ago
io_uring/rsrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[v2 PATCH] io_uring: rsrc: Optimize return value variable 'ret'
Posted by Li zeming 2 years, 10 months ago
The initialization assignment of the variable ret is changed to 0, only
in 'goto fail;' Use the ret variable as the function return value.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 v2: Modify the initialization value of ret variable.

 io_uring/rsrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 056f40946ff6..09a16d709cb5 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -410,7 +410,7 @@ __cold static int io_rsrc_data_alloc(struct io_ring_ctx *ctx,
 				     unsigned nr, struct io_rsrc_data **pdata)
 {
 	struct io_rsrc_data *data;
-	int ret = -ENOMEM;
+	int ret = 0;
 	unsigned i;
 
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
-- 
2.18.2
Re: [v2 PATCH] io_uring: rsrc: Optimize return value variable 'ret'
Posted by Jens Axboe 2 years, 11 months ago
On Sat, 18 Mar 2023 02:25:38 +0800, Li zeming wrote:
> The initialization assignment of the variable ret is changed to 0, only
> in 'goto fail;' Use the ret variable as the function return value.
> 
> 

Applied, thanks!

[1/1] io_uring: rsrc: Optimize return value variable 'ret'
      commit: 6acd352dfee558194643adbed7e849fe80fd1b93

Best regards,
-- 
Jens Axboe
Re: [v2 PATCH] io_uring: rsrc: Optimize return value variable 'ret'
Posted by Jens Axboe 2 years, 11 months ago
On 3/17/23 12:25 PM, Li zeming wrote:
> The initialization assignment of the variable ret is changed to 0, only
> in 'goto fail;' Use the ret variable as the function return value.

Applied - normally I'd just sent the usual auto-generated email,
but wanted to let you know that the previous email and this email
are all sent from the future. You need to fix your date/time on
your end.

-- 
Jens Axboe