[PATCH 2/2] bindings: regulator: pca9450: Add LOADSW regulator

Nicolas Heemeryck posted 2 patches 2 years, 11 months ago
[PATCH 2/2] bindings: regulator: pca9450: Add LOADSW regulator
Posted by Nicolas Heemeryck 2 years, 11 months ago
Add the binding documentation for the load switch regulator.

Signed-off-by: Nicolas Heemeryck <nicolas.heemeryck@devialet.com>
---
 .../bindings/regulator/nxp,pca9450-regulator.yaml  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
index 835b53302db8..064d57256aff 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -20,6 +20,7 @@ description: |
 #The valid names for PCA9450 regulator nodes are:
 #BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6,
 #LDO1, LDO2, LDO3, LDO4, LDO5
+#LOADSW
 #Note: Buck3 removed on PCA9450B and connect with Buck1 on PCA9450C.
 
 properties:
@@ -74,6 +75,14 @@ properties:
 
         unevaluatedProperties: false
 
+        "LOADSW":
+          type: object
+          $ref: regulator.yaml#
+          description:
+            Properties for LOAD SWITCH regulator.
+
+        unevaluatedProperties: false
+
     additionalProperties: false
 
   sd-vsel-gpios:
@@ -190,6 +199,11 @@ examples:
                     regulator-boot-on;
                     regulator-always-on;
                 };
+                loadsw: LOADSW {
+                    regulator-name = "LOADSW";
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
             };
         };
     };
-- 
2.34.1


-- 
- Confidential -
Re: [PATCH 2/2] bindings: regulator: pca9450: Add LOADSW regulator
Posted by Krzysztof Kozlowski 2 years, 11 months ago
On 17/03/2023 10:39, Nicolas Heemeryck wrote:
> Add the binding documentation for the load switch regulator.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed important mailing lists as well, thus patch won't be tested.
That's a NAK. :(

> 
> Signed-off-by: Nicolas Heemeryck <nicolas.heemeryck@devialet.com>
> ---
>  .../bindings/regulator/nxp,pca9450-regulator.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index 835b53302db8..064d57256aff 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -20,6 +20,7 @@ description: |
>  #The valid names for PCA9450 regulator nodes are:
>  #BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6,
>  #LDO1, LDO2, LDO3, LDO4, LDO5
> +#LOADSW
>  #Note: Buck3 removed on PCA9450B and connect with Buck1 on PCA9450C.
>  
>  properties:
> @@ -74,6 +75,14 @@ properties:
>  
>          unevaluatedProperties: false
>  
> +        "LOADSW":

Does not look like pattern... unless you want something-LOADSW, but then
why?



Best regards,
Krzysztof