[PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc()

Jiapeng Chong posted 1 patch 2 years, 11 months ago
drivers/mtd/nand/raw/mxc_nand.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc()
Posted by Jiapeng Chong 2 years, 11 months ago
The function is_imx51_nfc is defined in the mxc_nand.c file, but not
called elsewhere, so remove this unused function.

drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx51_nfc'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4559
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/mtd/nand/raw/mxc_nand.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
index f6c96341b896..16d795c25609 100644
--- a/drivers/mtd/nand/raw/mxc_nand.c
+++ b/drivers/mtd/nand/raw/mxc_nand.c
@@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
 	return host->devtype_data == &imx25_nand_devtype_data;
 }
 
-static inline int is_imx51_nfc(struct mxc_nand_host *host)
-{
-	return host->devtype_data == &imx51_nand_devtype_data;
-}
-
 static inline int is_imx53_nfc(struct mxc_nand_host *host)
 {
 	return host->devtype_data == &imx53_nand_devtype_data;
-- 
2.20.1.7.g153144c
Re: [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51_nfc()
Posted by Miquel Raynal 2 years, 10 months ago
Hi,

jiapeng.chong@linux.alibaba.com wrote on Fri, 17 Mar 2023 15:40:41
+0800:

> The function is_imx51_nfc is defined in the mxc_nand.c file, but not
> called elsewhere, so remove this unused function.
> 
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx51_nfc'.

Thanks for your patch, but apparently is_imx53_nfc() is also unused,
strange the robot did not pick this up. Anyway, no need to resend, I
received another patch removing both functions already.

> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4559
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/mtd/nand/raw/mxc_nand.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
> index f6c96341b896..16d795c25609 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
>  	return host->devtype_data == &imx25_nand_devtype_data;
>  }
>  
> -static inline int is_imx51_nfc(struct mxc_nand_host *host)
> -{
> -	return host->devtype_data == &imx51_nand_devtype_data;
> -}
> -
>  static inline int is_imx53_nfc(struct mxc_nand_host *host)
>  {
>  	return host->devtype_data == &imx53_nand_devtype_data;


Thanks,
Miquèl