[v1] io_uring: rsrc: Optimize return value variable 'ret'

[PATCH] io_uring: rsrc: Optimize return value variable 'ret'

Li zeming posted 1 patch 2 years, 11 months ago

Diff against v2
Download mbox

There is a newer version of this series

io_uring/rsrc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] io_uring: rsrc: Optimize return value variable 'ret'

Posted by Li zeming 2 years, 11 months ago

The function returns here and returns ret directly. It may look better.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 io_uring/rsrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 056f40946ff6..55dc2c505f8a 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -415,11 +415,11 @@ __cold static int io_rsrc_data_alloc(struct io_ring_ctx *ctx,
 
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
 	if (!data)
-		return -ENOMEM;
+		return ret;
 	data->tags = (u64 **)io_alloc_page_table(nr * sizeof(data->tags[0][0]));
 	if (!data->tags) {
 		kfree(data);
-		return -ENOMEM;
+		return ret;
 	}
 
 	data->nr = nr;
-- 
2.18.2

Re: [PATCH] io_uring: rsrc: Optimize return value variable 'ret'

Posted by Jens Axboe 2 years, 11 months ago

On 3/16/23 12:13 PM, Li zeming wrote:
> The function returns here and returns ret directly. It may look better.

I think it'd be better to just initialize 'ret' to 0 instead.

-- 
Jens Axboe