[PATCH] ASoC: codecs:rx-macro: Fixing uninitialized variables.

Ravulapati Vishnu Vardhan Rao posted 1 patch 3 years ago
sound/soc/codecs/lpass-rx-macro.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] ASoC: codecs:rx-macro: Fixing uninitialized variables.
Posted by Ravulapati Vishnu Vardhan Rao 3 years ago
Initializing the uninitialized variables to avoid any unexpected garbage
value to be propagated further.

Signed-off-by: Ravulapati Vishnu Vardhan Rao <quic_visr@quicinc.com>
---
 sound/soc/codecs/lpass-rx-macro.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
index a73a7d7a1c0a..0c8b79ff2fc5 100644
--- a/sound/soc/codecs/lpass-rx-macro.c
+++ b/sound/soc/codecs/lpass-rx-macro.c
@@ -2219,6 +2219,8 @@ static void rx_macro_hd2_control(struct snd_soc_component *component,
 				 u16 interp_idx, int event)
 {
 	u16 hd2_scale_reg, hd2_enable_reg;
+	hd2_scale_reg = 0;
+	hd2_enable_reg = 0;
 
 	switch (interp_idx) {
 	case INTERP_HPHL:
-- 
2.17.1
Re: [PATCH] ASoC: codecs:rx-macro: Fixing uninitialized variables.
Posted by Mark Brown 3 years ago
On Thu, Mar 16, 2023 at 09:52:49PM +0530, Ravulapati Vishnu Vardhan Rao wrote:

>  {
>  	u16 hd2_scale_reg, hd2_enable_reg;
> +	hd2_scale_reg = 0;
> +	hd2_enable_reg = 0;
>  
>  	switch (interp_idx) {
>  	case INTERP_HPHL:

This is just shutting the warning up, it's not like 0 is ever a sensible
value to use there.