[PATCH] block: remove obsolete config BLOCK_COMPAT

Lukas Bulwahn posted 1 patch 2 years, 11 months ago
block/Kconfig | 3 ---
1 file changed, 3 deletions(-)
[PATCH] block: remove obsolete config BLOCK_COMPAT
Posted by Lukas Bulwahn 2 years, 11 months ago
Before commit bdc1ddad3e5f ("compat_ioctl: block: move
blkdev_compat_ioctl() into ioctl.c"), the config BLOCK_COMPAT was used to
include compat_ioctl.c into the kernel build. With this commit, the code
is moved into ioctl.c and included with the config COMPAT. So, since then,
the config BLOCK_COMPAT has no effect and any further purpose.

Remove this obsolete config BLOCK_COMPAT.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 block/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index 5d9d9c84d516..941b2dca70db 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -204,9 +204,6 @@ config BLK_INLINE_ENCRYPTION_FALLBACK
 
 source "block/partitions/Kconfig"
 
-config BLOCK_COMPAT
-	def_bool COMPAT
-
 config BLK_MQ_PCI
 	def_bool PCI
 
-- 
2.17.1
Re: [PATCH] block: remove obsolete config BLOCK_COMPAT
Posted by Jens Axboe 2 years, 11 months ago
On Thu, 16 Mar 2023 12:16:30 +0100, Lukas Bulwahn wrote:
> Before commit bdc1ddad3e5f ("compat_ioctl: block: move
> blkdev_compat_ioctl() into ioctl.c"), the config BLOCK_COMPAT was used to
> include compat_ioctl.c into the kernel build. With this commit, the code
> is moved into ioctl.c and included with the config COMPAT. So, since then,
> the config BLOCK_COMPAT has no effect and any further purpose.
> 
> Remove this obsolete config BLOCK_COMPAT.
> 
> [...]

Applied, thanks!

[1/1] block: remove obsolete config BLOCK_COMPAT
      commit: 8f0d196e4dc137470bbd5de98278d941c8002fcb

Best regards,
-- 
Jens Axboe
Re: [PATCH] block: remove obsolete config BLOCK_COMPAT
Posted by Christoph Hellwig 2 years, 11 months ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Re: [PATCH] block: remove obsolete config BLOCK_COMPAT
Posted by Arnd Bergmann 2 years, 11 months ago
On Thu, Mar 16, 2023, at 12:16, Lukas Bulwahn wrote:
> Before commit bdc1ddad3e5f ("compat_ioctl: block: move
> blkdev_compat_ioctl() into ioctl.c"), the config BLOCK_COMPAT was used to
> include compat_ioctl.c into the kernel build. With this commit, the code
> is moved into ioctl.c and included with the config COMPAT. So, since then,
> the config BLOCK_COMPAT has no effect and any further purpose.
>
> Remove this obsolete config BLOCK_COMPAT.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Thanks for spotting this,

Acked-by: Arnd Bergmann <arnd@arndb.de>