[v1] Introduce Nuvoton ma35d1 SoC

[PATCH 02/15] arm64: defconfig: Add Nuvoton MA35 family support

Posted by Jacky Huang 2 years, 11 months ago

From: Jacky Huang <ychuang3@nuvoton.com>

Enable basic drivers for ma35d1 booting up support: architecture,
device tree, clock, reset, and uart.

Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7790ee42c68a..c96189acb02c 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -53,6 +53,7 @@ CONFIG_ARCH_LAYERSCAPE=y
 CONFIG_ARCH_MXC=y
 CONFIG_ARCH_S32=y
 CONFIG_ARCH_NPCM=y
+CONFIG_ARCH_NUVOTON=y
 CONFIG_ARCH_QCOM=y
 CONFIG_ARCH_RENESAS=y
 CONFIG_ARCH_ROCKCHIP=y
-- 
2.34.1

Re: [PATCH 02/15] arm64: defconfig: Add Nuvoton MA35 family support

Posted by Arnd Bergmann 2 years, 11 months ago

On Wed, Mar 15, 2023, at 08:28, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> Enable basic drivers for ma35d1 booting up support: architecture,
> device tree, clock, reset, and uart.
>
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>

The description does not seem to match the actual contents,
which only enable the platform but none of the drivers.

It's ok generally to enable options in the defconfig file
before you add the drivers, but if it's all part of a patch
series, I would probable more this bit to the end.

     Arnd

Re: [PATCH 02/15] arm64: defconfig: Add Nuvoton MA35 family support

Posted by Jacky Huang 2 years, 11 months ago

Hi Anrd,

Thanks for your advice.

On 2023/3/16 下午 10:23, Arnd Bergmann wrote:
> On Wed, Mar 15, 2023, at 08:28, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> Enable basic drivers for ma35d1 booting up support: architecture,
>> device tree, clock, reset, and uart.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> The description does not seem to match the actual contents,
> which only enable the platform but none of the drivers.

I would like to rewrite it as:

arm64: defconfig: Add support for Nuvoton MA35 family SoCs

This adds support for the Nuvoton MA35 family SoCs which
are based on the Cortex-A35 Armv8-A 64-bit architecture.


> It's ok generally to enable options in the defconfig file
> before you add the drivers, but if it's all part of a patch
> series, I would probable more this bit to the end.
>
>       Arnd

Best regards,

Jacky Huang