[PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path

Paran Lee posted 1 patch 2 years, 11 months ago
tools/perf/arch/common.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
[PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path
Posted by Paran Lee 2 years, 11 months ago
Add RISC-V binutils path on lookup triplets.

Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
 tools/perf/arch/common.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
index 59dd875fd5e4..e80d4d22cabf 100644
--- a/tools/perf/arch/common.c
+++ b/tools/perf/arch/common.c
@@ -43,6 +43,20 @@ const char *const powerpc_triplets[] = {
 	NULL
 };
 
+const char *const riscv32_triplets[] = {
+	"riscv32-unknown-linux-gnu-",
+	"riscv32-linux-android-",
+	"riscv32-linux-gnu-",
+	NULL
+};
+
+const char *const riscv64_triplets[] = {
+	"riscv64-unknown-linux-gnu-",
+	"riscv64-linux-android-",
+	"riscv64-linux-gnu-",
+	NULL
+};
+
 const char *const s390_triplets[] = {
 	"s390-ibm-linux-",
 	"s390x-linux-gnu-",
@@ -166,6 +180,10 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
 		path_list = arm64_triplets;
 	else if (!strcmp(arch, "powerpc"))
 		path_list = powerpc_triplets;
+	else if (!strcmp(arch, "riscv32"))
+		path_list = riscv32_triplets;
+	else if (!strcmp(arch, "riscv64"))
+		path_list = riscv64_triplets;
 	else if (!strcmp(arch, "sh"))
 		path_list = sh_triplets;
 	else if (!strcmp(arch, "s390"))
-- 
2.34.1
Re: [PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path
Posted by Palmer Dabbelt 2 years, 9 months ago
On Tue, 14 Mar 2023 22:15:01 PDT (-0700), p4ranlee@gmail.com wrote:
> Add RISC-V binutils path on lookup triplets.
>
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> ---
>  tools/perf/arch/common.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> index 59dd875fd5e4..e80d4d22cabf 100644
> --- a/tools/perf/arch/common.c
> +++ b/tools/perf/arch/common.c
> @@ -43,6 +43,20 @@ const char *const powerpc_triplets[] = {
>  	NULL
>  };
>
> +const char *const riscv32_triplets[] = {
> +	"riscv32-unknown-linux-gnu-",
> +	"riscv32-linux-android-",
> +	"riscv32-linux-gnu-",
> +	NULL
> +};
> +
> +const char *const riscv64_triplets[] = {
> +	"riscv64-unknown-linux-gnu-",
> +	"riscv64-linux-android-",
> +	"riscv64-linux-gnu-",
> +	NULL
> +};
> +
>  const char *const s390_triplets[] = {
>  	"s390-ibm-linux-",
>  	"s390x-linux-gnu-",
> @@ -166,6 +180,10 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
>  		path_list = arm64_triplets;
>  	else if (!strcmp(arch, "powerpc"))
>  		path_list = powerpc_triplets;
> +	else if (!strcmp(arch, "riscv32"))
> +		path_list = riscv32_triplets;
> +	else if (!strcmp(arch, "riscv64"))
> +		path_list = riscv64_triplets;
>  	else if (!strcmp(arch, "sh"))
>  		path_list = sh_triplets;
>  	else if (!strcmp(arch, "s390"))

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
Re: [PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path
Posted by Arnaldo Carvalho de Melo 2 years, 9 months ago
Em Tue, Apr 18, 2023 at 08:41:21PM -0700, Palmer Dabbelt escreveu:
> On Tue, 14 Mar 2023 22:15:01 PDT (-0700), p4ranlee@gmail.com wrote:
> > Add RISC-V binutils path on lookup triplets.
> > 
> > Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> > ---
> >  tools/perf/arch/common.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> > index 59dd875fd5e4..e80d4d22cabf 100644
> > --- a/tools/perf/arch/common.c
> > +++ b/tools/perf/arch/common.c
> > @@ -43,6 +43,20 @@ const char *const powerpc_triplets[] = {
> >  	NULL
> >  };
> > 
> > +const char *const riscv32_triplets[] = {
> > +	"riscv32-unknown-linux-gnu-",
> > +	"riscv32-linux-android-",
> > +	"riscv32-linux-gnu-",
> > +	NULL
> > +};
> > +
> > +const char *const riscv64_triplets[] = {
> > +	"riscv64-unknown-linux-gnu-",
> > +	"riscv64-linux-android-",
> > +	"riscv64-linux-gnu-",
> > +	NULL
> > +};
> > +
> >  const char *const s390_triplets[] = {
> >  	"s390-ibm-linux-",
> >  	"s390x-linux-gnu-",
> > @@ -166,6 +180,10 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
> >  		path_list = arm64_triplets;
> >  	else if (!strcmp(arch, "powerpc"))
> >  		path_list = powerpc_triplets;
> > +	else if (!strcmp(arch, "riscv32"))
> > +		path_list = riscv32_triplets;
> > +	else if (!strcmp(arch, "riscv64"))
> > +		path_list = riscv64_triplets;
> >  	else if (!strcmp(arch, "sh"))
> >  		path_list = sh_triplets;
> >  	else if (!strcmp(arch, "s390"))
> 
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks, applied.

- Arnaldo
Re: [PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path
Posted by Ian Rogers 2 years, 11 months ago
On Tue, Mar 14, 2023 at 10:15 PM Paran Lee <p4ranlee@gmail.com> wrote:
>
> Add RISC-V binutils path on lookup triplets.
>
> Signed-off-by: Paran Lee <p4ranlee@gmail.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/arch/common.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> index 59dd875fd5e4..e80d4d22cabf 100644
> --- a/tools/perf/arch/common.c
> +++ b/tools/perf/arch/common.c
> @@ -43,6 +43,20 @@ const char *const powerpc_triplets[] = {
>         NULL
>  };
>
> +const char *const riscv32_triplets[] = {
> +       "riscv32-unknown-linux-gnu-",
> +       "riscv32-linux-android-",
> +       "riscv32-linux-gnu-",
> +       NULL
> +};
> +
> +const char *const riscv64_triplets[] = {
> +       "riscv64-unknown-linux-gnu-",
> +       "riscv64-linux-android-",
> +       "riscv64-linux-gnu-",
> +       NULL
> +};
> +
>  const char *const s390_triplets[] = {
>         "s390-ibm-linux-",
>         "s390x-linux-gnu-",
> @@ -166,6 +180,10 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
>                 path_list = arm64_triplets;
>         else if (!strcmp(arch, "powerpc"))
>                 path_list = powerpc_triplets;
> +       else if (!strcmp(arch, "riscv32"))
> +               path_list = riscv32_triplets;
> +       else if (!strcmp(arch, "riscv64"))
> +               path_list = riscv64_triplets;
>         else if (!strcmp(arch, "sh"))
>                 path_list = sh_triplets;
>         else if (!strcmp(arch, "s390"))
> --
> 2.34.1
>