[v3] Staging: qlge: Fix indentation in conditional statement

[PATCH v3] Staging: qlge: Fix indentation in conditional statement

Posted by Sumitra Sharma 2 years, 11 months ago

Add tabs/spaces in conditional statements in to fix the
indentation.

Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>

---
v2: Fix indentation in conditional statement, noted by Dan Carpenter
 <error27@gmail.com>
v3: Apply changes to fresh git tree


 drivers/staging/qlge/qlge_dbg.c | 35 +++++++++++++++------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 66d28358342f..c7e865f515cf 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -351,26 +351,23 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
 		/* We're reading 400 xgmac registers, but we filter out
 		 * several locations that are non-responsive to reads.
 		 */
-		if ((i == 0x00000114) ||
-		    (i == 0x00000118) ||
-			(i == 0x0000013c) ||
-			(i == 0x00000140) ||
-			(i > 0x00000150 && i < 0x000001fc) ||
-			(i > 0x00000278 && i < 0x000002a0) ||
-			(i > 0x000002c0 && i < 0x000002cf) ||
-			(i > 0x000002dc && i < 0x000002f0) ||
-			(i > 0x000003c8 && i < 0x00000400) ||
-			(i > 0x00000400 && i < 0x00000410) ||
-			(i > 0x00000410 && i < 0x00000420) ||
-			(i > 0x00000420 && i < 0x00000430) ||
-			(i > 0x00000430 && i < 0x00000440) ||
-			(i > 0x00000440 && i < 0x00000450) ||
-			(i > 0x00000450 && i < 0x00000500) ||
-			(i > 0x0000054c && i < 0x00000568) ||
-			(i > 0x000005c8 && i < 0x00000600)) {
+		if ((i == 0x00000114) || (i == 0x00000118) ||
+		    (i == 0x0000013c) || (i == 0x00000140) ||
+		    (i > 0x00000150 && i < 0x000001fc) ||
+		    (i > 0x00000278 && i < 0x000002a0) ||
+		    (i > 0x000002c0 && i < 0x000002cf) ||
+		    (i > 0x000002dc && i < 0x000002f0) ||
+		    (i > 0x000003c8 && i < 0x00000400) ||
+		    (i > 0x00000400 && i < 0x00000410) ||
+		    (i > 0x00000410 && i < 0x00000420) ||
+		    (i > 0x00000420 && i < 0x00000430) ||
+		    (i > 0x00000430 && i < 0x00000440) ||
+		    (i > 0x00000440 && i < 0x00000450) ||
+		    (i > 0x00000450 && i < 0x00000500) ||
+		    (i > 0x0000054c && i < 0x00000568) ||
+		    (i > 0x000005c8 && i < 0x00000600)) {
 			if (other_function)
-				status =
-				qlge_read_other_func_xgmac_reg(qdev, i, buf);
+				status = qlge_read_other_func_xgmac_reg(qdev, i, buf);
 			else
 				status = qlge_read_xgmac_reg(qdev, i, buf);
 
-- 
2.25.1

Re: [PATCH v3] Staging: qlge: Fix indentation in conditional statement

Posted by Ira Weiny 2 years, 11 months ago

Sumitra Sharma wrote:
> Add tabs/spaces in conditional statements in to fix the
> indentation.
> 
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>

LGTM:

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

Re: [PATCH v3] Staging: qlge: Fix indentation in conditional statement

Posted by Dan Carpenter 2 years, 11 months ago

On Tue, Mar 14, 2023 at 05:11:52AM -0700, Sumitra Sharma wrote:
> Add tabs/spaces in conditional statements in to fix the
> indentation.
> 
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> 
> ---
> v2: Fix indentation in conditional statement, noted by Dan Carpenter
>  <error27@gmail.com>
> v3: Apply changes to fresh git tree
> 

Thanks!

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter

Re: [PATCH v3] Staging: qlge: Fix indentation in conditional statement

Posted by Sumitra Sharma 2 years, 11 months ago

On Wed, Mar 15, 2023 at 10:47:21AM +0300, Dan Carpenter wrote:
> On Tue, Mar 14, 2023 at 05:11:52AM -0700, Sumitra Sharma wrote:
> > Add tabs/spaces in conditional statements in to fix the
> > indentation.
> > 
> > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> > 
> > ---
> > v2: Fix indentation in conditional statement, noted by Dan Carpenter
> >  <error27@gmail.com>
> > v3: Apply changes to fresh git tree
> > 
> 
> Thanks!
> 
> Reviewed-by: Dan Carpenter <error27@gmail.com>
>

Hi dan,

Will this be considered as my first accepted patch? :)

Regards,

Sumitra
> regards,
> dan carpenter
>

Re: [PATCH v3] Staging: qlge: Fix indentation in conditional statement

Posted by Julia Lawall 2 years, 11 months ago


On Thu, 16 Mar 2023, Sumitra Sharma wrote:

> On Wed, Mar 15, 2023 at 10:47:21AM +0300, Dan Carpenter wrote:
> > On Tue, Mar 14, 2023 at 05:11:52AM -0700, Sumitra Sharma wrote:
> > > Add tabs/spaces in conditional statements in to fix the
> > > indentation.
> > >
> > > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> > >
> > > ---
> > > v2: Fix indentation in conditional statement, noted by Dan Carpenter
> > >  <error27@gmail.com>
> > > v3: Apply changes to fresh git tree
> > >
> >
> > Thanks!
> >
> > Reviewed-by: Dan Carpenter <error27@gmail.com>
> >
>
> Hi dan,
>
> Will this be considered as my first accepted patch? :)


I think it is accepted only when Greg takes it into his tree and you can
have a link for it.

julia

>
> Regards,
>
> Sumitra
> > regards,
> > dan carpenter
> >
>
>