[PATCH 0/2] regulator: Fix boot speed regression w/ off-on-delay-us

Douglas Anderson posted 2 patches 2 years, 11 months ago
drivers/regulator/core.c  | 7 +++----
drivers/regulator/fixed.c | 1 +
2 files changed, 4 insertions(+), 4 deletions(-)
[PATCH 0/2] regulator: Fix boot speed regression w/ off-on-delay-us
Posted by Douglas Anderson 2 years, 11 months ago
These two patches together fix a boot speed regression on
sc7180-trogdor boards which use off-on-delay-us together with
regulator-boot-on with the eDP power rail.

The first patch is _almost_ a revert of another patch. Depending on
when the regulator is probed and the actual delay, the end result
might be the same as a revert or might result in a delay that's
somewhere between "no delay" and a full delay. As talked about in the
patch, I believe this is the correct behavior and, if the problems
fixed in the original patch are still present, I'm hoping that they
can be fixed in a cleaner way.

The first patch doesn't fully eliminate the boot speed regression, it
only gets us back ~250 of the 500 ms delay. The second patch gets us
the rest of the way.

The two patches can be applied independently of each other.


Douglas Anderson (2):
  regulator: core: Shorten off-on-delay-us for always-on/boot-on by time
    since booted
  regulator: fixed: Set PROBE_PREFER_ASYNCHRONOUS

 drivers/regulator/core.c  | 7 +++----
 drivers/regulator/fixed.c | 1 +
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.40.0.rc1.284.g88254d51c5-goog
Re: (subset) [PATCH 0/2] regulator: Fix boot speed regression w/ off-on-delay-us
Posted by Mark Brown 2 years, 11 months ago
On Mon, 13 Mar 2023 11:18:18 -0700, Douglas Anderson wrote:
> These two patches together fix a boot speed regression on
> sc7180-trogdor boards which use off-on-delay-us together with
> regulator-boot-on with the eDP power rail.
> 
> The first patch is _almost_ a revert of another patch. Depending on
> when the regulator is probed and the actual delay, the end result
> might be the same as a revert or might result in a delay that's
> somewhere between "no delay" and a full delay. As talked about in the
> patch, I believe this is the correct behavior and, if the problems
> fixed in the original patch are still present, I'm hoping that they
> can be fixed in a cleaner way.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: core: Shorten off-on-delay-us for always-on/boot-on by time since booted
      commit: 691c1fcda5351ed98a44610b7dccc0e3ee920020

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark