[PATCH 1/4] dt-bindings: PCI: dwc: Add rk3588 compatible line

Lucas Tanure posted 4 patches 2 years, 11 months ago
There is a newer version of this series
[PATCH 1/4] dt-bindings: PCI: dwc: Add rk3588 compatible line
Posted by Lucas Tanure 2 years, 11 months ago
RK3588 uses the same driver as RK3568

Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
 Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
index 2be72ae1169f..91aa9070ee31 100644
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
@@ -23,6 +23,7 @@ properties:
   compatible:
     items:
       - const: rockchip,rk3568-pcie
+      - const: rockchip,rk3588-pcie
 
   reg:
     items:
-- 
2.39.2
Re: [PATCH 1/4] dt-bindings: PCI: dwc: Add rk3588 compatible line
Posted by Krzysztof Kozlowski 2 years, 11 months ago
On 13/03/2023 16:39, Lucas Tanure wrote:
> RK3588 uses the same driver as RK3568

Subject: drop line

Commit msg: drop driver and focus on hardware. Missing full stop.

> 
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
>  Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> index 2be72ae1169f..91aa9070ee31 100644
> --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> @@ -23,6 +23,7 @@ properties:
>    compatible:
>      items:
>        - const: rockchip,rk3568-pcie
> +      - const: rockchip,rk3588-pcie

According to your driver change, these are compatible, so maybe this
should be expressed in the bindings?

Best regards,
Krzysztof