[PATCH] iommu: omap: Use of_property_read_bool() for boolean properties

Rob Herring posted 1 patch 3 years, 1 month ago
drivers/iommu/omap-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] iommu: omap: Use of_property_read_bool() for boolean properties
Posted by Rob Herring 3 years, 1 month ago
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/iommu/omap-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 3ab078112a7c..baafd6211ac4 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -1191,7 +1191,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
 		return err;
 	if (obj->nr_tlb_entries != 32 && obj->nr_tlb_entries != 8)
 		return -EINVAL;
-	if (of_find_property(of, "ti,iommu-bus-err-back", NULL))
+	if (of_property_read_bool(of, "ti,iommu-bus-err-back"))
 		obj->has_bus_err_back = MMU_GP_REG_BUS_ERR_BACK_EN;
 
 	obj->dev = &pdev->dev;
-- 
2.39.2
Re: [PATCH] iommu: omap: Use of_property_read_bool() for boolean properties
Posted by Joerg Roedel 3 years ago
On Fri, Mar 10, 2023 at 08:47:09AM -0600, Rob Herring wrote:
>  drivers/iommu/omap-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied with minor style fixes in the commit message.
Re: [PATCH] iommu: omap: Use of_property_read_bool() for boolean properties
Posted by Robin Murphy 3 years, 1 month ago
On 2023-03-10 14:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   drivers/iommu/omap-iommu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 3ab078112a7c..baafd6211ac4 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1191,7 +1191,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
>   		return err;
>   	if (obj->nr_tlb_entries != 32 && obj->nr_tlb_entries != 8)
>   		return -EINVAL;
> -	if (of_find_property(of, "ti,iommu-bus-err-back", NULL))
> +	if (of_property_read_bool(of, "ti,iommu-bus-err-back"))
>   		obj->has_bus_err_back = MMU_GP_REG_BUS_ERR_BACK_EN;
>   
>   	obj->dev = &pdev->dev;