ARM: dts: stm32: Add coprocessor detach mbox on stm32mp15xx-osd32 SoM

[PATCH v1] ARM: dts: stm32: Add coprocessor detach mbox on stm32mp15xx-osd32 SoM

Posted by Leonard Göhrs 3 years, 1 month ago

To support the detach feature, add a new mailbox channel to inform
the remote processor on a detach. This signal allows the remote processor
firmware to stop IPC communication and to reinitialize the resources for
a re-attach.

See 6257dfc1c412dcdbd76ca5fa92c8444222dbe5b0 for a patch that does the
same for stm32mp15x-dkx boards.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
---
 arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
index 935b7084b5a2..a43965c86fe8 100644
--- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
@@ -210,8 +210,8 @@ &ipcc {
 &m4_rproc {
 	memory-region = <&retram>, <&mcuram>, <&mcuram2>, <&vdev0vring0>,
 			<&vdev0vring1>, <&vdev0buffer>;
-	mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>;
-	mbox-names = "vq0", "vq1", "shutdown";
+	mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>, <&ipcc 3>;
+	mbox-names = "vq0", "vq1", "shutdown", "detach";
 	interrupt-parent = <&exti>;
 	interrupts = <68 1>;
 	status = "okay";

base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
-- 
2.30.2

Re: [PATCH v1] ARM: dts: stm32: Add coprocessor detach mbox on stm32mp15xx-osd32 SoM

Posted by Alexandre TORGUE 3 years ago

Hi Leonard

On 3/10/23 10:26, Leonard Göhrs wrote:
> To support the detach feature, add a new mailbox channel to inform
> the remote processor on a detach. This signal allows the remote processor
> firmware to stop IPC communication and to reinitialize the resources for
> a re-attach.
> 
> See 6257dfc1c412dcdbd76ca5fa92c8444222dbe5b0 for a patch that does the
> same for stm32mp15x-dkx boards.
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
>   arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index 935b7084b5a2..a43965c86fe8 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -210,8 +210,8 @@ &ipcc {
>   &m4_rproc {
>   	memory-region = <&retram>, <&mcuram>, <&mcuram2>, <&vdev0vring0>,
>   			<&vdev0vring1>, <&vdev0buffer>;
> -	mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>;
> -	mbox-names = "vq0", "vq1", "shutdown";
> +	mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>, <&ipcc 3>;
> +	mbox-names = "vq0", "vq1", "shutdown", "detach";
>   	interrupt-parent = <&exti>;
>   	interrupts = <68 1>;
>   	status = "okay";
> 

Applied on stm32-next.

Thanks.
Alex

> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6

Re: [PATCH v1] ARM: dts: stm32: Add coprocessor detach mbox on stm32mp15xx-osd32 SoM

Posted by Ahmad Fatoum 3 years ago

On 10.03.23 10:26, Leonard Göhrs wrote:
> To support the detach feature, add a new mailbox channel to inform
> the remote processor on a detach. This signal allows the remote processor
> firmware to stop IPC communication and to reinitialize the resources for
> a re-attach.
> 
> See 6257dfc1c412dcdbd76ca5fa92c8444222dbe5b0 for a patch that does the
> same for stm32mp15x-dkx boards.
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index 935b7084b5a2..a43965c86fe8 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -210,8 +210,8 @@ &ipcc {
>  &m4_rproc {
>  	memory-region = <&retram>, <&mcuram>, <&mcuram2>, <&vdev0vring0>,
>  			<&vdev0vring1>, <&vdev0buffer>;
> -	mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>;
> -	mbox-names = "vq0", "vq1", "shutdown";
> +	mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>, <&ipcc 3>;
> +	mbox-names = "vq0", "vq1", "shutdown", "detach";
>  	interrupt-parent = <&exti>;
>  	interrupts = <68 1>;
>  	status = "okay";
> 
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |