md/raid10: several simple obvious bugfix

[PATCH v2 0/6] md/raid10: several simple obvious bugfix

Posted by Yu Kuai 3 years, 1 month ago

From: Yu Kuai <yukuai3@huawei.com>

We're running many tests for raid10 currently, and we found a lot of
problems already. This patchset is the first part for some simple and
obvious problems. Most of the patches were sent separately already, but
I think a patchset is better for review.

Yu Kuai (6):
  md/raid10: don't call bio_start_io_acct twice for bio which
    experienced read error
  md: fix soft lockup in status_resync
  md/raid10: don't BUG_ON() in raise_barrier()
  md/radi10: fix leak of 'r10bio->remaining' for recovery
  md/raid10: fix memleak for 'conf->bio_split'
  md/raid10: fix memleak of md thread

 drivers/md/md.c     | 18 +++++------
 drivers/md/raid10.c | 78 +++++++++++++++++++++++----------------------
 2 files changed, 49 insertions(+), 47 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/6] md/raid10: several simple obvious bugfix

Posted by Song Liu 3 years ago

On Thu, Mar 9, 2023 at 11:39 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@huawei.com>
>
> We're running many tests for raid10 currently, and we found a lot of
> problems already. This patchset is the first part for some simple and
> obvious problems. Most of the patches were sent separately already, but
> I think a patchset is better for review.
>
> Yu Kuai (6):
>   md/raid10: don't call bio_start_io_acct twice for bio which
>     experienced read error
>   md: fix soft lockup in status_resync
>   md/raid10: don't BUG_ON() in raise_barrier()
>   md/radi10: fix leak of 'r10bio->remaining' for recovery
>   md/raid10: fix memleak for 'conf->bio_split'
>   md/raid10: fix memleak of md thread

Applied 2/6 to 6/6 to md-next. Thanks!

Song

>
>  drivers/md/md.c     | 18 +++++------
>  drivers/md/raid10.c | 78 +++++++++++++++++++++++----------------------
>  2 files changed, 49 insertions(+), 47 deletions(-)
>
> --
> 2.31.1
>

Re: [PATCH v2 0/6] md/raid10: several simple obvious bugfix

Posted by Yu Kuai 3 years ago

Hi, Song!

在 2023/03/14 6:37, Song Liu 写道:
> On Thu, Mar 9, 2023 at 11:39 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>>
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> We're running many tests for raid10 currently, and we found a lot of
>> problems already. This patchset is the first part for some simple and
>> obvious problems. Most of the patches were sent separately already, but
>> I think a patchset is better for review.
>>

We had many testcase for raid10 locally，just consulte that is mdadm the
only place to push some new tests? We're maintaining tests through
blktests, is't ok if we push those tests to blktests?

Thanks,
Kuai

>> Yu Kuai (6):
>>    md/raid10: don't call bio_start_io_acct twice for bio which
>>      experienced read error
>>    md: fix soft lockup in status_resync
>>    md/raid10: don't BUG_ON() in raise_barrier()
>>    md/radi10: fix leak of 'r10bio->remaining' for recovery
>>    md/raid10: fix memleak for 'conf->bio_split'
>>    md/raid10: fix memleak of md thread
> 
> Applied 2/6 to 6/6 to md-next. Thanks!
> 
> Song
> 
>>
>>   drivers/md/md.c     | 18 +++++------
>>   drivers/md/raid10.c | 78 +++++++++++++++++++++++----------------------
>>   2 files changed, 49 insertions(+), 47 deletions(-)
>>
>> --
>> 2.31.1
>>
> .
>