[PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h

Muhammad Usama Anjum posted 1 patch 3 years, 1 month ago
drivers/net/ethernet/qlogic/qede/qede.h         | 2 --
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
2 files changed, 3 deletions(-)
[PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h
Posted by Muhammad Usama Anjum 3 years, 1 month ago
make versioncheck reports the following:
./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.

So remove linux/version.h from both of these files. Also remove
linux/compiler.h while at it as it is also not being used.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
Changes since v2:
- Correct subject and check patch application on net-next

Changes since v1:
- Remove linux/compiler.h as well
---
 drivers/net/ethernet/qlogic/qede/qede.h         | 2 --
 drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index f90dcfe9ee68..f9931ecb7baa 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -6,8 +6,6 @@
 
 #ifndef _QEDE_H_
 #define _QEDE_H_
-#include <linux/compiler.h>
-#include <linux/version.h>
 #include <linux/workqueue.h>
 #include <linux/netdevice.h>
 #include <linux/interrupt.h>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 8034d812d5a0..374a86b875a3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -4,7 +4,6 @@
  * Copyright (c) 2019-2020 Marvell International Ltd.
  */
 
-#include <linux/version.h>
 #include <linux/types.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
-- 
2.39.2
Re: [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 1 month ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 10 Mar 2023 03:52:05 +0500 you wrote:
> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files. Also remove
> linux/compiler.h while at it as it is also not being used.
> 
> [...]

Here is the summary with links:
  - [net-next,v3] qede: remove linux/version.h and linux/compiler.h
    https://git.kernel.org/netdev/net-next/c/95b744508d4d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h
Posted by Simon Horman 3 years, 1 month ago
On Fri, Mar 10, 2023 at 03:52:05AM +0500, Muhammad Usama Anjum wrote:
> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files. Also remove
> linux/compiler.h while at it as it is also not being used.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>