[PATCH] KVM: PPC: Mark three local functions "static"

Sean Christopherson posted 1 patch 2 years, 6 months ago
arch/powerpc/kvm/booke.c  | 5 +++--
arch/powerpc/kvm/e500mc.c | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
[PATCH] KVM: PPC: Mark three local functions "static"
Posted by Sean Christopherson 2 years, 6 months ago
Tag a few functions that are local and don't have a previous prototype as
"static".

No functional change intended.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202303031630.ntvIuYqo-lkp@intel.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
---

This was prompted by a new W=1 build warning for a commit that went in
through the KVM tree, but said commit has made its way to Linus, so it
shouldn't matter who grabs this.

 arch/powerpc/kvm/booke.c  | 5 +++--
 arch/powerpc/kvm/e500mc.c | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 01adffb24667..ce37d282be6d 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -623,7 +623,7 @@ static void arm_next_watchdog(struct kvm_vcpu *vcpu)
 	spin_unlock_irqrestore(&vcpu->arch.wdt_lock, flags);
 }
 
-void kvmppc_watchdog_func(struct timer_list *t)
+static void kvmppc_watchdog_func(struct timer_list *t)
 {
 	struct kvm_vcpu *vcpu = from_timer(vcpu, t, arch.wdt_timer);
 	u32 tsr, new_tsr;
@@ -1946,7 +1946,8 @@ static int kvmppc_booke_add_watchpoint(struct debug_reg *dbg_reg, uint64_t addr,
 	dbg_reg->dbcr0 |= DBCR0_IDM;
 	return 0;
 }
-void kvm_guest_protect_msr(struct kvm_vcpu *vcpu, ulong prot_bitmap, bool set)
+static void kvm_guest_protect_msr(struct kvm_vcpu *vcpu, ulong prot_bitmap,
+				  bool set)
 {
 	/* XXX: Add similar MSR protection for BookE-PR */
 #ifdef CONFIG_KVM_BOOKE_HV
diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c
index a309138927ff..d58df71ace58 100644
--- a/arch/powerpc/kvm/e500mc.c
+++ b/arch/powerpc/kvm/e500mc.c
@@ -168,7 +168,7 @@ static void kvmppc_core_vcpu_put_e500mc(struct kvm_vcpu *vcpu)
 	kvmppc_booke_vcpu_put(vcpu);
 }
 
-int kvmppc_e500mc_check_processor_compat(void)
+static int kvmppc_e500mc_check_processor_compat(void)
 {
 	int r;
 

base-commit: 63355b9884b3d1677de6bd1517cd2b8a9bf53978
-- 
2.40.0.rc1.284.g88254d51c5-goog
Re: [PATCH] KVM: PPC: Mark three local functions "static"
Posted by Michael Ellerman 2 years, 5 months ago
On Wed, 08 Mar 2023 15:24:37 -0800, Sean Christopherson wrote:
> Tag a few functions that are local and don't have a previous prototype as
> "static".
> 
> No functional change intended.
> 
> 

Applied to powerpc/topic/ppc-kvm.

[1/1] KVM: PPC: Mark three local functions "static"
      https://git.kernel.org/powerpc/c/e83ca8cfa286c9fc78b585b0e66df7f542bcbcf2

cheers
Re: [PATCH] KVM: PPC: Mark three local functions "static"
Posted by Michael Ellerman 2 years, 6 months ago
Sean Christopherson <seanjc@google.com> writes:
> Tag a few functions that are local and don't have a previous prototype as
> "static".
>
> No functional change intended.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303031630.ntvIuYqo-lkp@intel.com
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>
> This was prompted by a new W=1 build warning for a commit that went in
> through the KVM tree, but said commit has made its way to Linus, so it
> shouldn't matter who grabs this.

OK thanks. I'll take this via the powerpc tree for v6.4.

cheers