mips: ar71: include linux/gpio/driver.h

[PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Arnd Bergmann 2 years, 6 months ago

From: Arnd Bergmann <arnd@arndb.de>

The change to remove the implicit gpio/driver.h include was done
after fixing all the other users, but the ar7 file still needs
the same change.

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/mips/ar7/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
index ae0e01b9438f..4ed833b9cc2f 100644
--- a/arch/mips/ar7/gpio.c
+++ b/arch/mips/ar7/gpio.c
@@ -7,7 +7,7 @@
 
 #include <linux/init.h>
 #include <linux/export.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 
 #include <asm/mach-ar7/ar7.h>
 
-- 
2.39.2

Re: [PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Florian Fainelli 2 years, 6 months ago

On 3/8/23 06:52, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The change to remove the implicit gpio/driver.h include was done
> after fixing all the other users, but the ar7 file still needs
> the same change.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

s/ar71/ar7/ in the subject, with that:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

On 8/3/23 15:52, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The change to remove the implicit gpio/driver.h include was done
> after fixing all the other users, but the ar7 file still needs
> the same change.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   arch/mips/ar7/gpio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Linus Walleij 2 years, 6 months ago

On Wed, Mar 8, 2023 at 3:53 PM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> The change to remove the implicit gpio/driver.h include was done
> after fixing all the other users, but the ar7 file still needs
> the same change.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

If this is the only problem merging this set was amazingly painless.

Yours,
Linus Walleij

Re: [PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Andy Shevchenko 2 years, 6 months ago

On Wed, Mar 08, 2023 at 10:56:02PM +0100, Linus Walleij wrote:
> On Wed, Mar 8, 2023 at 3:53 PM Arnd Bergmann <arnd@kernel.org> wrote:
> 
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The change to remove the implicit gpio/driver.h include was done
> > after fixing all the other users, but the ar7 file still needs
> > the same change.
> >
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> If this is the only problem merging this set was amazingly painless.

Too early to celebrate. We have one more patch on the same matters.

That said, I will collect them and send a new PR to Bart.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Linus Walleij 2 years, 6 months ago

On Thu, Mar 9, 2023 at 3:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > If this is the only problem merging this set was amazingly painless.
>
> Too early to celebrate. We have one more patch on the same matters.

Yeah I would expect some more noise, I had a similar patch in one
of my kernelorg branches and the zeroday robot would spit some
weird bugs like this at me after a few days of randconfig builds.

Yours,
Linus Walleij

Re: [PATCH] mips: ar71: include linux/gpio/driver.h

Posted by Andy Shevchenko 2 years, 6 months ago

On Wed, Mar 08, 2023 at 03:52:53PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The change to remove the implicit gpio/driver.h include was done
> after fixing all the other users, but the ar7 file still needs
> the same change.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thank you!

P.S. Bart, I believe the best strategy here is to you directly apply this to
GPIO tree. If anyone needs this, you can make an immutable tag or branch with
it being included.

Alternatively I can take it and issue a new immutable tag.

Tell me which way suits you better.

> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/mips/ar7/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
> index ae0e01b9438f..4ed833b9cc2f 100644
> --- a/arch/mips/ar7/gpio.c
> +++ b/arch/mips/ar7/gpio.c
> @@ -7,7 +7,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  
>  #include <asm/mach-ar7/ar7.h>
>  
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko