1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells

Konrad Dybcio posted 1 patch 2 years, 6 months ago
There is a newer version of this series
.../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
1 file changed, 3 insertions(+)
[PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Posted by Konrad Dybcio 2 years, 6 months ago 
MPM provides a single genpd. Allow #power-domain-cells = <0>.

Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
index 509d20c091af..4c470dc143e5 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
@@ -62,6 +62,9 @@ properties:
         - description: MPM pin number
         - description: GIC SPI number for the MPM pin
 
+  '#power-domain-cells':
+    const: 0
+
 required:
   - compatible
   - reg
-- 
2.39.2
Re: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Posted by Krzysztof Kozlowski 2 years, 6 months ago 
On 08/03/2023 02:17, Konrad Dybcio wrote:
> MPM provides a single genpd. Allow #power-domain-cells = <0>.
> 
> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
>  1 file changed, 3 insertions(+)
> 

BTW, this can be also added to the example. Always useful to validate it.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Posted by Krzysztof Kozlowski 2 years, 6 months ago 
On 08/03/2023 02:17, Konrad Dybcio wrote:
> MPM provides a single genpd. Allow #power-domain-cells = <0>.
> 
> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Posted by Shawn Guo 2 years, 6 months ago 
On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> MPM provides a single genpd. Allow #power-domain-cells = <0>.
>
> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Acked-by: Shawn Guo <shawn.guo@linaro.org>
Re: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Posted by Shawn Guo 2 years, 6 months ago 
On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> MPM provides a single genpd. Allow #power-domain-cells = <0>.

Indeed! It was missing from the initial submission.  Thanks for fixing it up!

>
> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
> index 509d20c091af..4c470dc143e5 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
> @@ -62,6 +62,9 @@ properties:
>          - description: MPM pin number
>          - description: GIC SPI number for the MPM pin
>
> +  '#power-domain-cells':

Should we add it to the "required" list and examples?

Shawn

> +    const: 0
> +
>  required:
>    - compatible
>    - reg
> --
> 2.39.2
>
Re: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Posted by Konrad Dybcio 2 years, 6 months ago 

On 8.03.2023 08:24, Shawn Guo wrote:
> On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> MPM provides a single genpd. Allow #power-domain-cells = <0>.
> 
> Indeed! It was missing from the initial submission.  Thanks for fixing it up!
> 
>>
>> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml     | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
>> index 509d20c091af..4c470dc143e5 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
>> @@ -62,6 +62,9 @@ properties:
>>          - description: MPM pin number
>>          - description: GIC SPI number for the MPM pin
>>
>> +  '#power-domain-cells':
> 
> Should we add it to the "required" list and examples?
I was debating it.. it's definitely not *required*, as the
irqchip part works even without it and then on SoCs with MPM
but without PSCI the setup may be tricky..

About the example, both yes/no are okay for me

Konrad
> 
> Shawn
> 
>> +    const: 0
>> +
>>  required:
>>    - compatible
>>    - reg
>> --
>> 2.39.2
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.