[PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node

Neil Armstrong posted 3 patches 2 years, 6 months ago
[PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node
Posted by Neil Armstrong 2 years, 6 months ago
The node is incomplete and doesn't need a subnode, add the missing
properties and move everything to the root of qup-spi0-cs-state node.

Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index fe8b92954550..c25c68257412 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2807,10 +2807,10 @@ qup_i2c15_data_clk: qup-i2c15-data-clk-state {
 			};
 
 			qup_spi0_cs: qup-spi0-cs-state {
-				cs-pins {
-					pins = "gpio31";
-					function = "qup1_se0";
-				};
+				pins = "gpio31";
+				function = "qup1_se0";
+				drive-strength = <6>;
+				bias-disable;
 			};
 
 			qup_spi0_data_clk: qup-spi0-data-clk-state {

-- 
2.34.1
Re: [PATCH 2/3] arm64: dts: qcom: sm8550: fix qup_spi0_cs node
Posted by Konrad Dybcio 2 years, 6 months ago

On 8.03.2023 09:32, Neil Armstrong wrote:
> The node is incomplete and doesn't need a subnode, add the missing
> properties and move everything to the root of qup-spi0-cs-state node.
> 
> Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index fe8b92954550..c25c68257412 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2807,10 +2807,10 @@ qup_i2c15_data_clk: qup-i2c15-data-clk-state {
>  			};
>  
>  			qup_spi0_cs: qup-spi0-cs-state {
> -				cs-pins {
> -					pins = "gpio31";
> -					function = "qup1_se0";
> -				};
> +				pins = "gpio31";
> +				function = "qup1_se0";
> +				drive-strength = <6>;
> +				bias-disable;
>  			};
>  
>  			qup_spi0_data_clk: qup-spi0-data-clk-state {
>