[PATCH v5 2/4] drm/i915/display: use nop_clear_range instead of local function

Andrzej Hajda posted 4 patches 2 years, 6 months ago
There is a newer version of this series
[PATCH v5 2/4] drm/i915/display: use nop_clear_range instead of local function
Posted by Andrzej Hajda 2 years, 6 months ago
Since nop_clear_range is visible it can be used here.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dpt.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/drm/i915/display/intel_dpt.c
index ad1a37b515fb1c..eb9d1a6cbfb9dd 100644
--- a/drivers/gpu/drm/i915/display/intel_dpt.c
+++ b/drivers/gpu/drm/i915/display/intel_dpt.c
@@ -73,11 +73,6 @@ static void dpt_insert_entries(struct i915_address_space *vm,
 		gen8_set_pte(&base[i++], pte_encode | addr);
 }
 
-static void dpt_clear_range(struct i915_address_space *vm,
-			    u64 start, u64 length)
-{
-}
-
 static void dpt_bind_vma(struct i915_address_space *vm,
 			 struct i915_vm_pt_stash *stash,
 			 struct i915_vma_resource *vma_res,
@@ -291,7 +286,7 @@ intel_dpt_create(struct intel_framebuffer *fb)
 	i915_address_space_init(vm, VM_CLASS_DPT);
 
 	vm->insert_page = dpt_insert_page;
-	vm->clear_range = dpt_clear_range;
+	vm->clear_range = nop_clear_range;
 	vm->insert_entries = dpt_insert_entries;
 	vm->cleanup = dpt_cleanup;
 

-- 
2.34.1
Re: [PATCH v5 2/4] drm/i915/display: use nop_clear_range instead of local function
Posted by Andi Shyti 2 years, 6 months ago
Hi Andrzej,

On Wed, Mar 08, 2023 at 04:39:04PM +0100, Andrzej Hajda wrote:
> Since nop_clear_range is visible it can be used here.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi