1. Patchew
  2. linux
  3. View series

[PATCH] kbuild: Disallow DTB overlays to built from .dts named source files

Andrew Davis posted 1 patch 3 years, 1 month ago 
scripts/Makefile.lib | 3 ---
1 file changed, 3 deletions(-)
[PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Andrew Davis 3 years, 1 month ago 
As a follow up to the series allowing DTB overlays to built from .dtso
files. Now that all overlays have been renamed, remove the ability to
build from overlays from .dts files to prevent any files with the old
name from accidental being added.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 scripts/Makefile.lib | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 100a386fcd71..68d0134bdbf9 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -418,9 +418,6 @@ endif
 $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
 	$(call if_changed_dep,dtb)
 
-$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
-	$(call if_changed_dep,dtc)
-
 $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
 	$(call if_changed_dep,dtc)
 
-- 
2.39.2
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Nicolas Schier 3 years, 1 month ago 
On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
        ^^^^

The first "from" sounds superfluous to me.

Kind regards,
Nicolas
> name from accidental being added.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  scripts/Makefile.lib | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
>  $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>  	$(call if_changed_dep,dtb)
>  
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> -	$(call if_changed_dep,dtc)
> -
>  $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>  	$(call if_changed_dep,dtc)
>  
> -- 
> 2.39.2

-- 
epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Andrew Davis 3 years, 1 month ago 
On 3/8/23 10:56 AM, Nicolas Schier wrote:
> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
>> As a follow up to the series allowing DTB overlays to built from .dtso
>> files. Now that all overlays have been renamed, remove the ability to
>> build from overlays from .dts files to prevent any files with the old
>          ^^^^
> 
> The first "from" sounds superfluous to me.
> 

It is a typo, feel free to drop it locally whoever takes this patch.

Thanks,
Andrew

> Kind regards,
> Nicolas
>> name from accidental being added.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>>   scripts/Makefile.lib | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 100a386fcd71..68d0134bdbf9 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -418,9 +418,6 @@ endif
>>   $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>>   	$(call if_changed_dep,dtb)
>>   
>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>> -	$(call if_changed_dep,dtc)
>> -
>>   $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>>   	$(call if_changed_dep,dtc)
>>   
>> -- 
>> 2.39.2
>
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Andrew Davis 2 years, 11 months ago 
On 3/8/23 9:01 AM, Andrew Davis wrote:
> On 3/8/23 10:56 AM, Nicolas Schier wrote:
>> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
>>> As a follow up to the series allowing DTB overlays to built from .dtso
>>> files. Now that all overlays have been renamed, remove the ability to
>>> build from overlays from .dts files to prevent any files with the old
>>          ^^^^
>>
>> The first "from" sounds superfluous to me.
>>
> 
> It is a typo, feel free to drop it locally whoever takes this patch.
> 

Seems no one took this last cycle.. Still valid and applies for this one.

Andrew

> Thanks,
> Andrew
> 
>> Kind regards,
>> Nicolas
>>> name from accidental being added.
>>>
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>>   scripts/Makefile.lib | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>>> index 100a386fcd71..68d0134bdbf9 100644
>>> --- a/scripts/Makefile.lib
>>> +++ b/scripts/Makefile.lib
>>> @@ -418,9 +418,6 @@ endif
>>>   $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>>>       $(call if_changed_dep,dtb)
>>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>>> -    $(call if_changed_dep,dtc)
>>> -
>>>   $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>>>       $(call if_changed_dep,dtc)
>>> -- 
>>> 2.39.2
>>
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Masahiro Yamada 2 years, 10 months ago 
On Tue, May 16, 2023 at 1:49 AM Andrew Davis <afd@ti.com> wrote:
>
> On 3/8/23 9:01 AM, Andrew Davis wrote:
> > On 3/8/23 10:56 AM, Nicolas Schier wrote:
> >> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
> >>> As a follow up to the series allowing DTB overlays to built from .dtso
> >>> files. Now that all overlays have been renamed, remove the ability to
> >>> build from overlays from .dts files to prevent any files with the old
> >>          ^^^^
> >>
> >> The first "from" sounds superfluous to me.
> >>
> >
> > It is a typo, feel free to drop it locally whoever takes this patch.
> >
>
> Seems no one took this last cycle.. Still valid and applies for this one.


Seems it fell into a crack.

Now applied to linux-kbuild. Thanks.





> Andrew
>
> > Thanks,
> > Andrew
> >
> >> Kind regards,
> >> Nicolas
> >>> name from accidental being added.
> >>>
> >>> Signed-off-by: Andrew Davis <afd@ti.com>
> >>> ---
> >>>   scripts/Makefile.lib | 3 ---
> >>>   1 file changed, 3 deletions(-)
> >>>
> >>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> >>> index 100a386fcd71..68d0134bdbf9 100644
> >>> --- a/scripts/Makefile.lib
> >>> +++ b/scripts/Makefile.lib
> >>> @@ -418,9 +418,6 @@ endif
> >>>   $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> >>>       $(call if_changed_dep,dtb)
> >>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> >>> -    $(call if_changed_dep,dtc)
> >>> -
> >>>   $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> >>>       $(call if_changed_dep,dtc)
> >>> --
> >>> 2.39.2
> >>



-- 
Best Regards
Masahiro Yamada
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Andy Shevchenko 3 years, 1 month ago 
On Mon, Mar 06, 2023 at 04:47:52PM -0600, Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.

Since in the past I had a problem with unnecessary rebuilding, this removes
the rule, so should not bring a similar regression.

Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thank you.

> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  scripts/Makefile.lib | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
>  $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>  	$(call if_changed_dep,dtb)
>  
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> -	$(call if_changed_dep,dtc)
> -
>  $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>  	$(call if_changed_dep,dtc)
>  
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Geert Uytterhoeven 3 years, 1 month ago 
On Mon, Mar 6, 2023 at 11:48 PM Andrew Davis <afd@ti.com> wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <afd@ti.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Posted by Masahiro Yamada 3 years, 1 month ago 
On Tue, Mar 7, 2023 at 7:48 AM Andrew Davis <afd@ti.com> wrote:
>
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <afd@ti.com>

Acked-by: Masahiro Yamada <masahiroy@kernel.org>

if Rob picks this up.


> ---
>  scripts/Makefile.lib | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
>  $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>         $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> -       $(call if_changed_dep,dtc)
> -
>  $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>         $(call if_changed_dep,dtc)
>
> --
> 2.39.2
>


-- 
Best Regards
Masahiro Yamada

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.