[PATCH v2, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes

Yue Zhao posted 4 patches 3 years, 1 month ago
There is a newer version of this series
include/linux/swap.h |  8 ++++----
mm/memcontrol.c      | 18 +++++++++---------
2 files changed, 13 insertions(+), 13 deletions(-)
[PATCH v2, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes
Posted by Yue Zhao 3 years, 1 month ago
This patch series helps to prevent load/store tearing in
several cgroup knobs.

As kindly pointed out by Michal Hocko and Roman Gushchin
, the changelog has been rephrased.

Besides, more knobs were checked, according to kind suggestions
from Shakeel Butt and Muchun Song.

v1:
- Add [WRITE|READ]_ONCE for memcg->oom_group
v2:
- Rephrase changelog
- Add [WRITE|READ]_ONCE for memcg->oom_kill_disable,
 memcg->swappiness, vm_swappiness and memcg->soft_limit

Yue Zhao (4):
  mm, memcg: Prevent memory.oom.group load/store tearing
  mm, memcg: Prevent memory.swappiness load/store tearing
  mm, memcg: Prevent memory.oom_control load/store tearing
  mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing

 include/linux/swap.h |  8 ++++----
 mm/memcontrol.c      | 18 +++++++++---------
 2 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.17.1
Re: [PATCH v2, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes
Posted by Roman Gushchin 3 years, 1 month ago
On Mon, Mar 06, 2023 at 11:41:34PM +0800, Yue Zhao wrote:
> This patch series helps to prevent load/store tearing in
> several cgroup knobs.
> 
> As kindly pointed out by Michal Hocko and Roman Gushchin
> , the changelog has been rephrased.
> 
> Besides, more knobs were checked, according to kind suggestions
> from Shakeel Butt and Muchun Song.
> 
> v1:
> - Add [WRITE|READ]_ONCE for memcg->oom_group
> v2:
> - Rephrase changelog
> - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable,
>  memcg->swappiness, vm_swappiness and memcg->soft_limit
> 
> Yue Zhao (4):
>   mm, memcg: Prevent memory.oom.group load/store tearing
>   mm, memcg: Prevent memory.swappiness load/store tearing
>   mm, memcg: Prevent memory.oom_control load/store tearing
>   mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing

Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
for the series.

Thank you!
Re: [PATCH v2, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes
Posted by Shakeel Butt 3 years, 1 month ago
On Mon, Mar 6, 2023 at 7:42 AM Yue Zhao <findns94@gmail.com> wrote:
>
> This patch series helps to prevent load/store tearing in
> several cgroup knobs.
>
> As kindly pointed out by Michal Hocko and Roman Gushchin
> , the changelog has been rephrased.
>
> Besides, more knobs were checked, according to kind suggestions
> from Shakeel Butt and Muchun Song.
>
> v1:
> - Add [WRITE|READ]_ONCE for memcg->oom_group
> v2:
> - Rephrase changelog
> - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable,
>  memcg->swappiness, vm_swappiness and memcg->soft_limit
>

Thanks Yue and for the whole series:

Acked-by: Shakeel Butt <shakeelb@google.com>