.../ABI/testing/sysfs-class-led-trigger-tty | 18 +++ drivers/leds/trigger/ledtrig-tty.c | 145 ++++++++++++++++-- drivers/tty/tty_io.c | 28 +++- include/linux/tty.h | 1 + 4 files changed, 171 insertions(+), 21 deletions(-)
Hello, here commes v8 of this series to add additional tty_led_modes. v8: Changes compared to the v7 patchset with 20230222083335.847655-1-fe@dev.tdt.de are. * Update 'Documentation/ABI/testing/sysfs-class-led-trigger-tty' with the suggested changes. * Use a meaningfull name for the Rx/Tx enum. * Do not use C++ comments style Add a new patch 'ledtrig-tty-fix-brightness-set' to fix an issue with LEDs that are connected via GPIOs to the SOC with the device driver 'leds-gpio'. In my view, the wrong function is being used here. LEDs that do not need and do not have a delayed call do not work with the current implementation. Therefore, the 'led_set_brightness_nosleep' function must be used. v7: Changes compared to the v5 patchset with 20230222075539.484878-1-fe@dev.tdt.de are. Addressed review comments by Jiri Slaby are: Thanks for the hint with the command 'make htmldocs SPHINXDIRS="admin-guide"'. Unfortunately, I did not know that. I have now verified it also in the browser. In my opinion, the list is now also displayed correctly in the documentation. v6: Changes compared to the v5 patchset with 20230221081901.15557-1-fe@dev.tdt.de are. Addressed review comments by kernel test robot are: * fix Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING: Unexpected indentation. * fix Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING: Block quote ends without a blank line; unexpected unindent. Thanks to Jiri Slaby, who gave me the crucial hint of what I need to fix, to possibly make the 'Kernel test robot' happy. v5: Changes compared to the v4 patchset with 20230220152038.3877596-1-fe@dev.tdt.de are. Sorry for the inconvenience, but I sent the wrong patch for ledtrig-tty.c in v4. The v5 patchset now includes all the changes I specified in the v4 patchset. v4: Changes compared to the v3 patchset with 20230220093739.320478-1-fe@dev.tdt.de are. Addressed review comments by Jiri Slaby are: ledtrig-tty.c: - Do not use __TTY_LED_MAX pattern us instead __TTY_LED_LAST = TTY_LED_RNG - Move declartion and assignment into one singel line - Use __TTY_LED_LAST pattern, to simplify tty_mode_show and tty_mode_store handling v3: Changes compared to the v2 patchset with 20230217094403.1574468-1-fe@dev.tdt.de are. Addressed review comments by Greg K-H are: tty.h: - Fix first comment line and remark -%ENOTTY for the new function 'tty_get_mget' to make a proper kernel doc. - Add the return value -%ENOTTY again, I thought it was no longer needed. v2: Changes compared to the initial patchset with 20230213140638.620206-1-fe@dev.tdt.de are. Addressed review comments by Jiri Slaby are: tty.h: - Fix compilation error because of wrong rebaseing - Remove empty lines - Use new 'tty_get_mget' in 'tty_tiocmget' ledtrig-tty.c: - Update commit description - Use enum for tty_led_mod in struct ledtrig_tty_date - Rename sysfs file from 'mode' to 'tty_led_mode' - Change tty_led_mode show function to use loop instead of switch/case - Change tty_led_mode store function to use loop instead of switch/case - Check return value of function tty_get_mget Florian Eckert (3): tty: new helper function tty_get_mget trigger: ledtrig-tty: add additional modes ledtrig-tty: call correct brightness set function .../ABI/testing/sysfs-class-led-trigger-tty | 18 +++ drivers/leds/trigger/ledtrig-tty.c | 145 ++++++++++++++++-- drivers/tty/tty_io.c | 28 +++- include/linux/tty.h | 1 + 4 files changed, 171 insertions(+), 21 deletions(-) -- 2.30.2
On 06. 03. 23, 10:41, Florian Eckert wrote: > Hello, > > here commes v8 of this series to add additional tty_led_modes. I think u r 2 fast. Uwe had some more comments on v7. Don't be afraid to wait some days after the last comments ;). As it is, it makes the review harder... > v8: > Changes compared to the v7 patchset with > 20230222083335.847655-1-fe@dev.tdt.de are. > > * Update 'Documentation/ABI/testing/sysfs-class-led-trigger-tty' > with the suggested changes. > * Use a meaningfull name for the Rx/Tx enum. > * Do not use C++ comments style > > Add a new patch 'ledtrig-tty-fix-brightness-set' to fix an issue with > LEDs that are connected via GPIOs to the SOC with the device driver > 'leds-gpio'. In my view, the wrong function is being used here. LEDs > that do not need and do not have a delayed call do not work with the > current implementation. Therefore, the 'led_set_brightness_nosleep' > function must be used. > > > v7: > Changes compared to the v5 patchset with > 20230222075539.484878-1-fe@dev.tdt.de are. > > Addressed review comments by Jiri Slaby are: > > Thanks for the hint with the command 'make htmldocs SPHINXDIRS="admin-guide"'. > Unfortunately, I did not know that. I have now verified it also in the > browser. In my opinion, the list is now also displayed correctly in > the documentation. > > > v6: > Changes compared to the v5 patchset with > 20230221081901.15557-1-fe@dev.tdt.de are. > > Addressed review comments by kernel test robot are: > > * fix Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: > WARNING: Unexpected indentation. > * fix Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: > WARNING: Block quote ends without a blank line; unexpected unindent. > > Thanks to Jiri Slaby, who gave me the crucial hint of what I need to fix, > to possibly make the 'Kernel test robot' happy. > > > v5: > Changes compared to the v4 patchset with > 20230220152038.3877596-1-fe@dev.tdt.de are. > > Sorry for the inconvenience, but I sent the wrong patch for > ledtrig-tty.c in v4. The v5 patchset now includes all the changes I > specified in the v4 patchset. > > > v4: > Changes compared to the v3 patchset with > 20230220093739.320478-1-fe@dev.tdt.de are. > > Addressed review comments by Jiri Slaby are: > > ledtrig-tty.c: > - Do not use __TTY_LED_MAX pattern us instead __TTY_LED_LAST = TTY_LED_RNG > - Move declartion and assignment into one singel line > - Use __TTY_LED_LAST pattern, to simplify tty_mode_show and > tty_mode_store handling > > > v3: > Changes compared to the v2 patchset with > 20230217094403.1574468-1-fe@dev.tdt.de are. > > Addressed review comments by Greg K-H are: > > tty.h: > - Fix first comment line and remark -%ENOTTY for the new function > 'tty_get_mget' to make a proper kernel doc. > - Add the return value -%ENOTTY again, I thought it was no longer needed. > > > v2: > Changes compared to the initial patchset with > 20230213140638.620206-1-fe@dev.tdt.de are. > > Addressed review comments by Jiri Slaby are: > > tty.h: > - Fix compilation error because of wrong rebaseing > - Remove empty lines > - Use new 'tty_get_mget' in 'tty_tiocmget' > > ledtrig-tty.c: > - Update commit description > - Use enum for tty_led_mod in struct ledtrig_tty_date > - Rename sysfs file from 'mode' to 'tty_led_mode' > - Change tty_led_mode show function to use loop instead of switch/case > - Change tty_led_mode store function to use loop instead of switch/case > - Check return value of function tty_get_mget > > Florian Eckert (3): > tty: new helper function tty_get_mget > trigger: ledtrig-tty: add additional modes > ledtrig-tty: call correct brightness set function > > .../ABI/testing/sysfs-class-led-trigger-tty | 18 +++ > drivers/leds/trigger/ledtrig-tty.c | 145 ++++++++++++++++-- > drivers/tty/tty_io.c | 28 +++- > include/linux/tty.h | 1 + > 4 files changed, 171 insertions(+), 21 deletions(-) > -- js suse labs
>> >> here commes v8 of this series to add additional tty_led_modes. > > I think u r 2 fast. Uwe had some more comments on v7. > > Don't be afraid to wait some days after the last comments ;). As it > is, it makes the review harder... > That was probably a race condition ;-) This must have been received when I sent the v8.
© 2016 - 2025 Red Hat, Inc.