[v1] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default

[PATCH v1 tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default

Posted by Kumaravel Thiagarajan 3 years, 1 month ago

Commit 32bb477fa7bf ("serial: 8250_pci1xxxx: Add driver for quad-uart
support") made the SERIAL_8250_PCI1XXXX driver enabled when SERIAL_8250
is enabled, disable it as this driver need not be enabled by default

Reported-by: Linus Torvalds <torvalds@linux-foundation.org> 
Link: https://lore.kernel.org/lkml/CAHk-=whhFCeeuo6vTEmNSx6S-KKkugxgzN_W5Z6v-9yH9gc3Zw@mail.gmail.com/
Fixes: 32bb477fa7bf ("serial: 8250_pci1xxxx: Add driver for quad-uart support")

Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
---
v0 -> v1:
- Add proper commit description
---
 drivers/tty/serial/8250/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 978dc196c29b..cbf11147dc89 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -299,7 +299,6 @@ config SERIAL_8250_PCI1XXXX
 	tristate "Microchip 8250 based serial port"
 	depends on SERIAL_8250 && PCI
 	select SERIAL_8250_PCILIB
-	default SERIAL_8250
 	help
 	 Select this option if you have a setup with Microchip PCIe
 	 Switch with serial port enabled and wish to enable 8250
-- 
2.25.1

Re: [PATCH v1 tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default

Posted by Geert Uytterhoeven 3 years, 1 month ago

On Fri, Mar 3, 2023 at 7:29 PM Kumaravel Thiagarajan
<kumaravel.thiagarajan@microchip.com> wrote:
> Commit 32bb477fa7bf ("serial: 8250_pci1xxxx: Add driver for quad-uart
> support") made the SERIAL_8250_PCI1XXXX driver enabled when SERIAL_8250
> is enabled, disable it as this driver need not be enabled by default

does not need to be enabled

>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Link: https://lore.kernel.org/lkml/CAHk-=whhFCeeuo6vTEmNSx6S-KKkugxgzN_W5Z6v-9yH9gc3Zw@mail.gmail.com/
> Fixes: 32bb477fa7bf ("serial: 8250_pci1xxxx: Add driver for quad-uart support")
>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
> v0 -> v1:
> - Add proper commit description

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds