Input: i8042 - Add quirk for Fujitsu Lifebook A574/H

[PATCH] Input: i8042 - Add quirk for Fujitsu Lifebook A574/H

Posted by Jonathan Denose 3 years, 1 month ago

Fujitsu Lifebook A574/H requires the nomux option to properly
probe the touchpad, especially when waking from sleep.

Signed-off-by: Jonathan Denose <jdenose@google.com>
---

 drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
index efc61736099b..fe7ffe30997c 100644
--- a/drivers/input/serio/i8042-acpipnpio.h
+++ b/drivers/input/serio/i8042-acpipnpio.h
@@ -610,6 +610,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
 		},
 		.driver_data = (void *)(SERIO_QUIRK_NOMUX)
 	},
+	{
+		/* Fujitsu Lifebook A574/H */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "FMVA0501PZ"),
+		},
+		.driver_data = (void *)(SERIO_QUIRK_NOMUX)
+	},
 	{
 		/* Gigabyte M912 */
 		.matches = {
-- 
2.40.0.rc0.216.gc4246ad0f0-goog

Re: [PATCH] Input: i8042 - Add quirk for Fujitsu Lifebook A574/H

Posted by Dmitry Torokhov 3 years ago

On Fri, Mar 03, 2023 at 09:26:23AM -0600, Jonathan Denose wrote:
> Fujitsu Lifebook A574/H requires the nomux option to properly
> probe the touchpad, especially when waking from sleep.
> 
> Signed-off-by: Jonathan Denose <jdenose@google.com>

Applied, thank you.

-- 
Dmitry

Re: [PATCH] Input: i8042 - Add quirk for Fujitsu Lifebook A574/H

Posted by Hans de Goede 3 years, 1 month ago

Hi,

On 3/3/23 16:26, Jonathan Denose wrote:
> Fujitsu Lifebook A574/H requires the nomux option to properly
> probe the touchpad, especially when waking from sleep.
> 
> Signed-off-by: Jonathan Denose <jdenose@google.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
> 
>  drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
> index efc61736099b..fe7ffe30997c 100644
> --- a/drivers/input/serio/i8042-acpipnpio.h
> +++ b/drivers/input/serio/i8042-acpipnpio.h
> @@ -610,6 +610,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
>  		},
>  		.driver_data = (void *)(SERIO_QUIRK_NOMUX)
>  	},
> +	{
> +		/* Fujitsu Lifebook A574/H */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "FMVA0501PZ"),
> +		},
> +		.driver_data = (void *)(SERIO_QUIRK_NOMUX)
> +	},
>  	{
>  		/* Gigabyte M912 */
>  		.matches = {

Re: [PATCH] Input: i8042 - Add quirk for Fujitsu Lifebook A574/H

Posted by Jonathan Denose 3 years ago

Hello Hans,

Thank you very much for your review.

For my knowledge, what is the timeline for patches in the input
mailing list getting applied to a maintainer branch after review?

Best,
Jonathan

On Mon, Mar 6, 2023 at 5:00 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 3/3/23 16:26, Jonathan Denose wrote:
> > Fujitsu Lifebook A574/H requires the nomux option to properly
> > probe the touchpad, especially when waking from sleep.
> >
> > Signed-off-by: Jonathan Denose <jdenose@google.com>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
>
>
> > ---
> >
> >  drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
> > index efc61736099b..fe7ffe30997c 100644
> > --- a/drivers/input/serio/i8042-acpipnpio.h
> > +++ b/drivers/input/serio/i8042-acpipnpio.h
> > @@ -610,6 +610,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
> >               },
> >               .driver_data = (void *)(SERIO_QUIRK_NOMUX)
> >       },
> > +     {
> > +             /* Fujitsu Lifebook A574/H */
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "FMVA0501PZ"),
> > +             },
> > +             .driver_data = (void *)(SERIO_QUIRK_NOMUX)
> > +     },
> >       {
> >               /* Gigabyte M912 */
> >               .matches = {
>

Re: [PATCH] Input: i8042 - Add quirk for Fujitsu Lifebook A574/H

Posted by Hans de Goede 3 years ago

Hi,

On 3/15/23 22:39, Jonathan Denose wrote:
> Hello Hans,
> 
> Thank you very much for your review.
> 
> For my knowledge, what is the timeline for patches in the input
> mailing list getting applied to a maintainer branch after review?

It depends on when Dmitry has time to go through the patch queue. Not a really helpful answer I know, sorry.

Regards,

Hans


> On Mon, Mar 6, 2023 at 5:00 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi,
>>
>> On 3/3/23 16:26, Jonathan Denose wrote:
>>> Fujitsu Lifebook A574/H requires the nomux option to properly
>>> probe the touchpad, especially when waking from sleep.
>>>
>>> Signed-off-by: Jonathan Denose <jdenose@google.com>
>>
>> Thanks, patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Regards,
>>
>> Hans
>>
>>
>>> ---
>>>
>>>  drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
>>> index efc61736099b..fe7ffe30997c 100644
>>> --- a/drivers/input/serio/i8042-acpipnpio.h
>>> +++ b/drivers/input/serio/i8042-acpipnpio.h
>>> @@ -610,6 +610,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
>>>               },
>>>               .driver_data = (void *)(SERIO_QUIRK_NOMUX)
>>>       },
>>> +     {
>>> +             /* Fujitsu Lifebook A574/H */
>>> +             .matches = {
>>> +                     DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
>>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "FMVA0501PZ"),
>>> +             },
>>> +             .driver_data = (void *)(SERIO_QUIRK_NOMUX)
>>> +     },
>>>       {
>>>               /* Gigabyte M912 */
>>>               .matches = {
>>
>