[PATCH 2/3] ASoC: dt-bindings: maxim,max9867: add "mclk" property

richard.leitner@linux.dev posted 3 patches 3 years, 1 month ago
There is a newer version of this series
[PATCH 2/3] ASoC: dt-bindings: maxim,max9867: add "mclk" property
Posted by richard.leitner@linux.dev 3 years, 1 month ago
From: Richard Leitner <richard.leitner@skidata.com>

Add clocks and clock-names properties to require a "mclk" definition for
the maxim,max9867 codec.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
index cefa43c3d34e..152340fe9cc7 100644
--- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
+++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
@@ -35,9 +35,17 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: "mclk"
+
 required:
   - compatible
   - reg
+  - clocks
+  - clock-names
 
 examples:
   - |
@@ -46,6 +54,8 @@ examples:
                     compatible = "maxim,max9867";
                     #sound-dai-cells = <0>;
                     reg = <0x18>;
+                    clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI3_MCLK1>;
+                    clock-names = "mclk";
             };
     };
 ...

-- 
2.39.2
Re: [PATCH 2/3] ASoC: dt-bindings: maxim,max9867: add "mclk" property
Posted by Krzysztof Kozlowski 3 years, 1 month ago
On 02/03/2023 12:55, richard.leitner@linux.dev wrote:
> From: Richard Leitner <richard.leitner@skidata.com>
> 
> Add clocks and clock-names properties to require a "mclk" definition for
> the maxim,max9867 codec.
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
>  Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
> index cefa43c3d34e..152340fe9cc7 100644
> --- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
> +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
> @@ -35,9 +35,17 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: "mclk"

Drop entire property, you do not need it for one clock.

Best regards,
Krzysztof
Re: [PATCH 2/3] ASoC: dt-bindings: maxim,max9867: add "mclk" property
Posted by Richard Leitner 3 years, 1 month ago
On Thu, Mar 02, 2023 at 02:31:45PM +0100, Krzysztof Kozlowski wrote:
> On 02/03/2023 12:55, richard.leitner@linux.dev wrote:
> > From: Richard Leitner <richard.leitner@skidata.com>
> > 
> > Add clocks and clock-names properties to require a "mclk" definition for
> > the maxim,max9867 codec.
> > 
> > Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> > ---
> >  Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
> > index cefa43c3d34e..152340fe9cc7 100644
> > --- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
> > +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml
> > @@ -35,9 +35,17 @@ properties:
> >    reg:
> >      maxItems: 1
> >  
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    const: "mclk"
> 
> Drop entire property, you do not need it for one clock.

Thanks. Will fix that in v2.

> 
> Best regards,
> Krzysztof
> 

regards;rl