ext4: Fix comment about the 64BIT feature

[PATCH] ext4: Fix comment about the 64BIT feature

Posted by Tudor Ambarus 2 years, 6 months ago

64BIT is part of the incompatible feature set, update the comment
accordingly.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 fs/ext4/ext4.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 140e1eb300d1..85c153e120b9 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1387,7 +1387,7 @@ struct ext4_super_block {
 	__le32	s_first_meta_bg;	/* First metablock block group */
 	__le32	s_mkfs_time;		/* When the filesystem was created */
 	__le32	s_jnl_blocks[17];	/* Backup of the journal inode */
-	/* 64bit support valid if EXT4_FEATURE_COMPAT_64BIT */
+	/* 64bit support valid if EXT4_FEATURE_INCOMPAT_64BIT */
 /*150*/	__le32	s_blocks_count_hi;	/* Blocks count */
 	__le32	s_r_blocks_count_hi;	/* Reserved blocks count */
 	__le32	s_free_blocks_count_hi;	/* Free blocks count */
-- 
2.39.2.722.g9855ee24e9-goog

Re: [PATCH] ext4: Fix comment about the 64BIT feature

Posted by Theodore Ts'o 2 years, 6 months ago

On Wed, 1 Mar 2023 13:38:42 +0000, Tudor Ambarus wrote:
> 64BIT is part of the incompatible feature set, update the comment
> accordingly.
> 
> 

Applied, thanks!

[1/1] ext4: Fix comment about the 64BIT feature
      commit: 7fc1f5c28ae4c615ccc5346f39a7bf4c4e0900ac

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>

Re: [PATCH] ext4: Fix comment about the 64BIT feature

Posted by Darrick J. Wong 2 years, 6 months ago

On Wed, Mar 01, 2023 at 01:38:42PM +0000, Tudor Ambarus wrote:
> 64BIT is part of the incompatible feature set, update the comment
> accordingly.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
>  fs/ext4/ext4.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 140e1eb300d1..85c153e120b9 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1387,7 +1387,7 @@ struct ext4_super_block {
>  	__le32	s_first_meta_bg;	/* First metablock block group */
>  	__le32	s_mkfs_time;		/* When the filesystem was created */
>  	__le32	s_jnl_blocks[17];	/* Backup of the journal inode */
> -	/* 64bit support valid if EXT4_FEATURE_COMPAT_64BIT */
> +	/* 64bit support valid if EXT4_FEATURE_INCOMPAT_64BIT */

Correct.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  /*150*/	__le32	s_blocks_count_hi;	/* Blocks count */
>  	__le32	s_r_blocks_count_hi;	/* Reserved blocks count */
>  	__le32	s_free_blocks_count_hi;	/* Free blocks count */
> -- 
> 2.39.2.722.g9855ee24e9-goog
>