watchdog: imx2_wdg: Declare local symbols static

[PATCH] watchdog: imx2_wdg: Declare local symbols static

Posted by Guenter Roeck 2 years, 6 months ago

0-day complains:

drivers/watchdog/imx2_wdt.c:442:22: sparse:
	symbol 'imx_wdt' was not declared. Should it be static?
drivers/watchdog/imx2_wdt.c:446:22: sparse:
	symbol 'imx_wdt_legacy' was not declared. Should it be static?

Declare as static variables.

Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
Cc: Andrej Picej <andrej.picej@norik.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/watchdog/imx2_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 19ab7b3d286b..6fcc3596103c 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -439,11 +439,11 @@ static int __maybe_unused imx2_wdt_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(imx2_wdt_pm_ops, imx2_wdt_suspend,
 			 imx2_wdt_resume);
 
-struct imx2_wdt_data imx_wdt = {
+static struct imx2_wdt_data imx_wdt = {
 	.wdw_supported = true,
 };
 
-struct imx2_wdt_data imx_wdt_legacy = {
+static struct imx2_wdt_data imx_wdt_legacy = {
 	.wdw_supported = false,
 };
 
-- 
2.39.1

Re: [PATCH] watchdog: imx2_wdg: Declare local symbols static

Posted by Andrej Picej 2 years, 6 months ago

On 28. 02. 23 16:16, Guenter Roeck wrote:
> 0-day complains:
> 
> drivers/watchdog/imx2_wdt.c:442:22: sparse:
> 	symbol 'imx_wdt' was not declared. Should it be static?
> drivers/watchdog/imx2_wdt.c:446:22: sparse:
> 	symbol 'imx_wdt_legacy' was not declared. Should it be static?
> 
> Declare as static variables.
> 
> Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
> Cc: Andrej Picej <andrej.picej@norik.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Hi Guenter,

thanks for the fix. Sorry for the trouble.

Best regards,
Andrej