[PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state()

Uwe Kleine-König posted 4 patches 2 years, 6 months ago
[PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state()
Posted by Uwe Kleine-König 2 years, 6 months ago
The driver only both polarities. Complete the implementation of
.get_state() by setting .polarity according to the configured hardware
state.

Fixes: d09f00810850 ("pwm: Add PWM driver for HiSilicon BVT SOCs")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-hibvt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c
index 12c05c155cab..1b9274c5ad87 100644
--- a/drivers/pwm/pwm-hibvt.c
+++ b/drivers/pwm/pwm-hibvt.c
@@ -146,6 +146,7 @@ static int hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
 
 	value = readl(base + PWM_CTRL_ADDR(pwm->hwpwm));
 	state->enabled = (PWM_ENABLE_MASK & value);
+	state->polarity = (PWM_POLARITY_MASK & value) ? PWM_POLARITY_INVERSED : PWM_POLARITY_NORMAL;
 
 	return 0;
 }
-- 
2.39.1

Re: [PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state()
Posted by Uwe Kleine-König 2 years, 6 months ago
[dropped yuanjian from To, as their address bounced when I submitted
this patch]

On Tue, Feb 28, 2023 at 02:55:05PM +0100, Uwe Kleine-König wrote:
> The driver only both polarities. Complete the implementation of

s/only/supports/

> .get_state() by setting .polarity according to the configured hardware
> state.
> 
> Fixes: d09f00810850 ("pwm: Add PWM driver for HiSilicon BVT SOCs")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |