drivers/power/supply/mt6360_charger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
From: Kang Chen <void0red@gmail.com>
devm_work_autocancel may fails, add a check and return early.
Signed-off-by: Kang Chen <void0red@gmail.com>
---
drivers/power/supply/mt6360_charger.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/mt6360_charger.c b/drivers/power/supply/mt6360_charger.c
index 92e48e3a4..1305cba61 100644
--- a/drivers/power/supply/mt6360_charger.c
+++ b/drivers/power/supply/mt6360_charger.c
@@ -796,7 +796,9 @@ static int mt6360_charger_probe(struct platform_device *pdev)
mci->vinovp = 6500000;
mutex_init(&mci->chgdet_lock);
platform_set_drvdata(pdev, mci);
- devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work);
+ ret = devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work);
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "Failed to set delayed work\n");
ret = device_property_read_u32(&pdev->dev, "richtek,vinovp-microvolt", &mci->vinovp);
if (ret)
--
2.34.1
Hi, On Mon, Feb 27, 2023 at 11:14:10AM +0800, void0red wrote: > From: Kang Chen <void0red@gmail.com> > > devm_work_autocancel may fails, add a check and return early. > > Signed-off-by: Kang Chen <void0red@gmail.com> > --- Thanks, queued to my fixes branch with Fixes tag added. -- Sebastian > drivers/power/supply/mt6360_charger.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/power/supply/mt6360_charger.c b/drivers/power/supply/mt6360_charger.c > index 92e48e3a4..1305cba61 100644 > --- a/drivers/power/supply/mt6360_charger.c > +++ b/drivers/power/supply/mt6360_charger.c > @@ -796,7 +796,9 @@ static int mt6360_charger_probe(struct platform_device *pdev) > mci->vinovp = 6500000; > mutex_init(&mci->chgdet_lock); > platform_set_drvdata(pdev, mci); > - devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work); > + ret = devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "Failed to set delayed work\n"); > > ret = device_property_read_u32(&pdev->dev, "richtek,vinovp-microvolt", &mci->vinovp); > if (ret) > -- > 2.34.1 >
© 2016 - 2024 Red Hat, Inc.