[PATCH v4 08/10] drm/i915: Correct type of wakeref variable

Andrzej Hajda posted 10 patches 3 years, 1 month ago
There is a newer version of this series
[PATCH v4 08/10] drm/i915: Correct type of wakeref variable
Posted by Andrzej Hajda 3 years, 1 month ago
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 978820f8697059..c35f551193c9ad 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -3235,7 +3235,7 @@ static void destroyed_worker_func(struct work_struct *w)
 	struct intel_guc *guc = container_of(w, struct intel_guc,
 					     submission_state.destroyed_worker);
 	struct intel_gt *gt = guc_to_gt(guc);
-	int tmp;
+	intel_wakeref_t tmp;
 
 	with_intel_gt_pm(gt, tmp)
 		deregister_destroyed_contexts(guc);

-- 
2.34.1
Re: [Intel-gfx] [PATCH v4 08/10] drm/i915: Correct type of wakeref variable
Posted by Andi Shyti 3 years ago
Hi Andrzej,

On Mon, Mar 06, 2023 at 05:32:04PM +0100, Andrzej Hajda wrote:
> Wakeref has dedicated type. Assumption it will be int
> compatible forever is incorrect.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

easy...

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Andi