fs/f2fs/checkpoint.c | 2 +- fs/f2fs/f2fs.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
After commit 26b5a079197c ("f2fs: cleanup dirty pages if recover failed"),
f2fs_sync_inode_meta() is only used in checkpoint.c, so
f2fs_sync_inode_meta() should only be visible inside. Delete the
declaration in the header file and change f2fs_sync_inode_meta()
to static.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
fs/f2fs/checkpoint.c | 2 +-
fs/f2fs/f2fs.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index c3e058e0a018..57e8ca187dc7 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -1133,7 +1133,7 @@ int f2fs_sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type,
goto retry;
}
-int f2fs_sync_inode_meta(struct f2fs_sb_info *sbi)
+static int f2fs_sync_inode_meta(struct f2fs_sb_info *sbi)
{
struct list_head *head = &sbi->inode_list[DIRTY_META];
struct inode *inode;
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index b0ab2062038a..3c95c8b75a23 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3737,7 +3737,6 @@ void f2fs_set_dirty_device(struct f2fs_sb_info *sbi, nid_t ino,
unsigned int devidx, int type);
bool f2fs_is_dirty_device(struct f2fs_sb_info *sbi, nid_t ino,
unsigned int devidx, int type);
-int f2fs_sync_inode_meta(struct f2fs_sb_info *sbi);
int f2fs_acquire_orphan_inode(struct f2fs_sb_info *sbi);
void f2fs_release_orphan_inode(struct f2fs_sb_info *sbi);
void f2fs_add_orphan_inode(struct inode *inode);
--
2.25.1
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Thu, 23 Feb 2023 01:25:13 +0000 you wrote: > After commit 26b5a079197c ("f2fs: cleanup dirty pages if recover failed"), > f2fs_sync_inode_meta() is only used in checkpoint.c, so > f2fs_sync_inode_meta() should only be visible inside. Delete the > declaration in the header file and change f2fs_sync_inode_meta() > to static. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> > > [...] Here is the summary with links: - [f2fs-dev,-next] f2fs: make f2fs_sync_inode_meta() static https://git.kernel.org/jaegeuk/f2fs/c/e6bd5463fce0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On 2023/2/23 9:25, Li Zetao wrote: > After commit 26b5a079197c ("f2fs: cleanup dirty pages if recover failed"), > f2fs_sync_inode_meta() is only used in checkpoint.c, so > f2fs_sync_inode_meta() should only be visible inside. Delete the > declaration in the header file and change f2fs_sync_inode_meta() > to static. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
© 2016 - 2025 Red Hat, Inc.