[v6] tools/nolibc: Adding stdint.h, more integer types and tests

[PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

Posted by Vincent Dagonneau 2 years, 6 months ago

Hi,

This is version 6 of the patch to add stdint.h to nolibc. Previous
versions of this patch are available here:

* v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
* v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
* v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
* v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
* v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/

This version integrates the feedback from Thomas, removing the limits
for ssize_t (not required by the standard) as well as multiple cosmetic
  issues.

Vincent.

Vincent Dagonneau (4):
  tools/nolibc: Adding stdint.h
  tools/nolibc: Adding integer types and integer limit macros
  tools/nolibc: Enlarging column width of tests
  tools/nolibc: Adds tests for the integer limits in stdint.h

 tools/include/nolibc/Makefile                |   4 +-
 tools/include/nolibc/std.h                   |  15 +-
 tools/include/nolibc/stdint.h                |  84 +++++++++++
 tools/testing/selftests/nolibc/nolibc-test.c | 139 ++++++++++++-------
 4 files changed, 177 insertions(+), 65 deletions(-)
 create mode 100644 tools/include/nolibc/stdint.h

-- 
2.39.1

Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

Posted by Thomas Weißschuh 2 years, 6 months ago

On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
> Hi,
> 
> This is version 6 of the patch to add stdint.h to nolibc. Previous
> versions of this patch are available here:
> 
> * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
> * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
> * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
> * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
> * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
> 
> This version integrates the feedback from Thomas, removing the limits
> for ssize_t (not required by the standard) as well as multiple cosmetic
>   issues.

Thanks, for the whole series:

Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

Note:

When sending new revisions it makes sense to add reviewers and
commenters of the previous versions on Cc.

It makes it easier for them and gives you a faster review or
Reviewed-by.

> Vincent.
> 
> Vincent Dagonneau (4):
>   tools/nolibc: Adding stdint.h
>   tools/nolibc: Adding integer types and integer limit macros
>   tools/nolibc: Enlarging column width of tests
>   tools/nolibc: Adds tests for the integer limits in stdint.h
> 
>  tools/include/nolibc/Makefile                |   4 +-
>  tools/include/nolibc/std.h                   |  15 +-
>  tools/include/nolibc/stdint.h                |  84 +++++++++++
>  tools/testing/selftests/nolibc/nolibc-test.c | 139 ++++++++++++-------
>  4 files changed, 177 insertions(+), 65 deletions(-)
>  create mode 100644 tools/include/nolibc/stdint.h
> 
> -- 
> 2.39.1
>

Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

Posted by Vincent Dagonneau 2 years, 6 months ago


On Wed, Feb 22, 2023, at 20:53, Thomas Weißschuh wrote:
> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
>> Hi,
>> 
>> This is version 6 of the patch to add stdint.h to nolibc. Previous
>> versions of this patch are available here:
>> 
>> * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
>> * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
>> * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
>> * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
>> * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
>> 
>> This version integrates the feedback from Thomas, removing the limits
>> for ssize_t (not required by the standard) as well as multiple cosmetic
>>   issues.
>
> Thanks, for the whole series:
>
> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
>
> Note:
>
> When sending new revisions it makes sense to add reviewers and
> commenters of the previous versions on Cc.
>
> It makes it easier for them and gives you a faster review or
> Reviewed-by.
>

Noted. Thank you for the reviews!

>> Vincent.
>> 
>> Vincent Dagonneau (4):
>>   tools/nolibc: Adding stdint.h
>>   tools/nolibc: Adding integer types and integer limit macros
>>   tools/nolibc: Enlarging column width of tests
>>   tools/nolibc: Adds tests for the integer limits in stdint.h
>> 
>>  tools/include/nolibc/Makefile                |   4 +-
>>  tools/include/nolibc/std.h                   |  15 +-
>>  tools/include/nolibc/stdint.h                |  84 +++++++++++
>>  tools/testing/selftests/nolibc/nolibc-test.c | 139 ++++++++++++-------
>>  4 files changed, 177 insertions(+), 65 deletions(-)
>>  create mode 100644 tools/include/nolibc/stdint.h
>> 
>> -- 
>> 2.39.1
>>

Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

Posted by Willy Tarreau 2 years, 6 months ago

On Thu, Feb 23, 2023 at 01:53:06AM +0000, Thomas Weißschuh wrote:
> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
> > Hi,
> > 
> > This is version 6 of the patch to add stdint.h to nolibc. Previous
> > versions of this patch are available here:
> > 
> > * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
> > * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
> > * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
> > * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
> > * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
> > 
> > This version integrates the feedback from Thomas, removing the limits
> > for ssize_t (not required by the standard) as well as multiple cosmetic
> >   issues.
> 
> Thanks, for the whole series:
> 
> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

Thanks to you both! I'll take care of all this this week-end.

> Note:
> 
> When sending new revisions it makes sense to add reviewers and
> commenters of the previous versions on Cc.
> 
> It makes it easier for them and gives you a faster review or
> Reviewed-by.

Agreed. Overall I find that for his first patchset Vincent has
done a great job ;-)

Cheers,
Willy

Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

Posted by Vincent Dagonneau 2 years, 6 months ago

On Wed, Feb 22, 2023, at 21:56, Willy Tarreau wrote:
> On Thu, Feb 23, 2023 at 01:53:06AM +0000, Thomas Weißschuh wrote:
>> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
>> > Hi,
>> > 
>> > This is version 6 of the patch to add stdint.h to nolibc. Previous
>> > versions of this patch are available here:
>> > 
>> > * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@vda.io/
>> > * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@vda.io/
>> > * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
>> > * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
>> > * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
>> > 
>> > This version integrates the feedback from Thomas, removing the limits
>> > for ssize_t (not required by the standard) as well as multiple cosmetic
>> >   issues.
>> 
>> Thanks, for the whole series:
>> 
>> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
>
> Thanks to you both! I'll take care of all this this week-end.
>
>> Note:
>> 
>> When sending new revisions it makes sense to add reviewers and
>> commenters of the previous versions on Cc.
>> 
>> It makes it easier for them and gives you a faster review or
>> Reviewed-by.
>
> Agreed. Overall I find that for his first patchset Vincent has
> done a great job ;-)
>

Thank you for your guidance on this patchset!

> Cheers,
> Willy