1. Patchew
  2. linux
  3. [PATCH 0/4] Devicetree support for Loongson-1 GPIO
  4. View patch

[PATCH 1/4] gpio: loongson1: Update copyright

Keguang Zhang posted 4 patches 2 years, 6 months ago
There is a newer version of this series
[PATCH 1/4] gpio: loongson1: Update copyright
Posted by Keguang Zhang 2 years, 6 months ago 
This patch updates copyright and author information.

Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
 drivers/gpio/gpio-loongson1.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c
index 5d90b3bc5a25..7ecbc43f8b38 100644
--- a/drivers/gpio/gpio-loongson1.c
+++ b/drivers/gpio/gpio-loongson1.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * GPIO Driver for Loongson 1 SoC
  *
- * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com>
- *
- * This file is licensed under the terms of the GNU General Public
- * License version 2. This program is licensed "as is" without any
- * warranty of any kind, whether express or implied.
+ * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com>
  */
 
 #include <linux/module.h>
@@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = {
 
 module_platform_driver(ls1x_gpio_driver);
 
-MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>");
+MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>");
 MODULE_DESCRIPTION("Loongson1 GPIO driver");
 MODULE_LICENSE("GPL");
-- 
2.34.1
Re: [PATCH 1/4] gpio: loongson1: Update copyright
Posted by andy.shevchenko@gmail.com 2 years, 6 months ago 
Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti:
> This patch updates copyright and author information.

...

> +// SPDX-License-Identifier: GPL-2.0-or-later

Have you talked to your lawers? This is an inequivalent to what was written
below.

>  /*
>   * GPIO Driver for Loongson 1 SoC
>   *
> - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com>
> - *
> - * This file is licensed under the terms of the GNU General Public
> - * License version 2. This program is licensed "as is" without any
> - * warranty of any kind, whether express or implied.
> + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com>
>   */

...

> -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>");
> +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>");

So, which name here is in your official documents?

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 1/4] gpio: loongson1: Update copyright
Posted by Kelvin Cheung 2 years, 6 months ago 
On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote:
>
> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti:
> > This patch updates copyright and author information.
>
> ...
>
> > +// SPDX-License-Identifier: GPL-2.0-or-later
>
> Have you talked to your lawers? This is an inequivalent to what was written
> below.
>
Yes.
> >  /*
> >   * GPIO Driver for Loongson 1 SoC
> >   *
> > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com>
> > - *
> > - * This file is licensed under the terms of the GNU General Public
> > - * License version 2. This program is licensed "as is" without any
> > - * warranty of any kind, whether express or implied.
> > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com>
> >   */
>
> ...
>
> > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>");
> > +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>");
>
> So, which name here is in your official documents?
>
Keguang Zhang is my official.

> --
> With Best Regards,
> Andy Shevchenko
>
>


--
Best regards,

Kelvin Cheung
Re: [PATCH 1/4] gpio: loongson1: Update copyright
Posted by Krzysztof Kozlowski 2 years, 6 months ago 
On 02/03/2023 12:09, Kelvin Cheung wrote:
> On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote:
>>
>> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti:
>>> This patch updates copyright and author information.
>>
>> ...
>>
>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>
>> Have you talked to your lawers? This is an inequivalent to what was written
>> below.
>>
> Yes.

Yes to what? You now change the license... and commit msg does not
explain it and does not justifies it. What is even weirder that your
lawyers agreed on GPLv3! With GPLv3 you need to open a lot from your
products... Not mentioning that they agreed on future GPLv4 and GPLv5,
that's even weirder because GPLv4 might be saying you need to buy me
flowers...

Best regards,
Krzysztof
Re: [PATCH 1/4] gpio: loongson1: Update copyright
Posted by Kelvin Cheung 2 years, 6 months ago 
On Thu, Mar 2, 2023 at 7:40 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 02/03/2023 12:09, Kelvin Cheung wrote:
> > On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote:
> >>
> >> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti:
> >>> This patch updates copyright and author information.
> >>
> >> ...
> >>
> >>> +// SPDX-License-Identifier: GPL-2.0-or-later
> >>
> >> Have you talked to your lawers? This is an inequivalent to what was written
> >> below.
> >>
> > Yes.
>
> Yes to what? You now change the license... and commit msg does not
> explain it and does not justifies it. What is even weirder that your
> lawyers agreed on GPLv3! With GPLv3 you need to open a lot from your
> products... Not mentioning that they agreed on future GPLv4 and GPLv5,
> that's even weirder because GPLv4 might be saying you need to buy me
> flowers...
>
If so, I choose to leave the license as is.
Is "GPL-2.0-only" right?

> Best regards,
> Krzysztof
>


-- 
Best regards,

Kelvin Cheung
Re: [PATCH 1/4] gpio: loongson1: Update copyright
Posted by Andy Shevchenko 2 years, 6 months ago 
On Thu, Mar 2, 2023 at 2:16 PM Kelvin Cheung <keguang.zhang@gmail.com> wrote:
> On Thu, Mar 2, 2023 at 7:40 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 02/03/2023 12:09, Kelvin Cheung wrote:
> > > On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote:
> > >> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti:
> > >>> This patch updates copyright and author information.
> > >>
> > >> ...
> > >>
> > >>> +// SPDX-License-Identifier: GPL-2.0-or-later
> > >>
> > >> Have you talked to your lawyers? This is an inequivalent to what was written
> > >> below.
> > >>
> > > Yes.
> >
> > Yes to what? You now change the license... and commit msg does not
> > explain it and does not justify it. What is even weirder that your
> > lawyers agreed on GPLv3! With GPLv3 you need to open a lot from your
> > products... Not mentioning that they agreed on future GPLv4 and GPLv5,
> > that's even weirder because GPLv4 might be saying you need to buy me
> > flowers...
> >
> If so, I choose to leave the license as is.
> Is "GPL-2.0-only" right?

We do not know.
It depends on what your company lawyers told you.

-- 
With Best Regards,
Andy Shevchenko

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.