[PATCH net v333 0/4] net: phy: EEE fixes

Oleksij Rempel posted 4 patches 2 years, 6 months ago
drivers/net/phy/phy-c45.c    | 54 ++++++++++++++++++++++++++++--------
drivers/net/phy/phy_device.c | 21 +++++++++++++-
include/linux/phy.h          |  6 ++++
3 files changed, 68 insertions(+), 13 deletions(-)
[PATCH net v333 0/4] net: phy: EEE fixes
Posted by Oleksij Rempel 2 years, 6 months ago
changes v3:
- add kernel test robot tags to commit log
- reword comment for genphy_c45_an_config_eee_aneg() function

changes v2:
- restore previous ethtool set logic for the case where advertisements
  are not provided by user space.
- use ethtool_convert_legacy_u32_to_link_mode() where possible
- genphy_c45_an_config_eee_aneg(): move adv initialization in to the if
  scope.

Different EEE related fixes.

Oleksij Rempel (4):
  net: phy: c45: use "supported_eee" instead of supported for access
    validation
  net: phy: c45: add genphy_c45_an_config_eee_aneg() function
  net: phy: do not force EEE support
  net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes

 drivers/net/phy/phy-c45.c    | 54 ++++++++++++++++++++++++++++--------
 drivers/net/phy/phy_device.c | 21 +++++++++++++-
 include/linux/phy.h          |  6 ++++
 3 files changed, 68 insertions(+), 13 deletions(-)

-- 
2.30.2
Re: [PATCH net v333 0/4] net: phy: EEE fixes
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 6 months ago
Hello:

This series was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 22 Feb 2023 06:50:39 +0100 you wrote:
> changes v3:
> - add kernel test robot tags to commit log
> - reword comment for genphy_c45_an_config_eee_aneg() function
> 
> changes v2:
> - restore previous ethtool set logic for the case where advertisements
>   are not provided by user space.
> - use ethtool_convert_legacy_u32_to_link_mode() where possible
> - genphy_c45_an_config_eee_aneg(): move adv initialization in to the if
>   scope.
> 
> [...]

Here is the summary with links:
  - [net,v3,1/4] net: phy: c45: use "supported_eee" instead of supported for access validation
    https://git.kernel.org/netdev/net/c/e209519b6233
  - [net,v3,2/4] net: phy: c45: add genphy_c45_an_config_eee_aneg() function
    https://git.kernel.org/netdev/net/c/b6478b8c9330
  - [net,v3,3/4] net: phy: do not force EEE support
    https://git.kernel.org/netdev/net/c/3eeca4e199ce
  - [net,v3,4/4] net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes
    https://git.kernel.org/netdev/net/c/186b1da76b72

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v333 0/4] net: phy: EEE fixes
Posted by Paolo Abeni 2 years, 6 months ago
Hi,

On Wed, 2023-02-22 at 06:50 +0100, Oleksij Rempel wrote:
> changes v3:
> - add kernel test robot tags to commit log
> - reword comment for genphy_c45_an_config_eee_aneg() function
> 
> changes v2:
> - restore previous ethtool set logic for the case where advertisements
>   are not provided by user space.
> - use ethtool_convert_legacy_u32_to_link_mode() where possible
> - genphy_c45_an_config_eee_aneg(): move adv initialization in to the if
>   scope.
> 
> Different EEE related fixes.
> 
> Oleksij Rempel (4):
>   net: phy: c45: use "supported_eee" instead of supported for access
>     validation
>   net: phy: c45: add genphy_c45_an_config_eee_aneg() function
>   net: phy: do not force EEE support
>   net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes
> 
>  drivers/net/phy/phy-c45.c    | 54 ++++++++++++++++++++++++++++--------
>  drivers/net/phy/phy_device.c | 21 +++++++++++++-
>  include/linux/phy.h          |  6 ++++
>  3 files changed, 68 insertions(+), 13 deletions(-)
> 
@Russel: I read your last reply to the v2 series as an ack here, am I
correct?

Thanks!

Paolo
Re: [PATCH net v333 0/4] net: phy: EEE fixes
Posted by Russell King (Oracle) 2 years, 6 months ago
On Thu, Feb 23, 2023 at 10:23:20AM +0100, Paolo Abeni wrote:
> Hi,
> 
> On Wed, 2023-02-22 at 06:50 +0100, Oleksij Rempel wrote:
> > changes v3:
> > - add kernel test robot tags to commit log
> > - reword comment for genphy_c45_an_config_eee_aneg() function
> > 
> > changes v2:
> > - restore previous ethtool set logic for the case where advertisements
> >   are not provided by user space.
> > - use ethtool_convert_legacy_u32_to_link_mode() where possible
> > - genphy_c45_an_config_eee_aneg(): move adv initialization in to the if
> >   scope.
> > 
> > Different EEE related fixes.
> > 
> > Oleksij Rempel (4):
> >   net: phy: c45: use "supported_eee" instead of supported for access
> >     validation
> >   net: phy: c45: add genphy_c45_an_config_eee_aneg() function
> >   net: phy: do not force EEE support
> >   net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes
> > 
> >  drivers/net/phy/phy-c45.c    | 54 ++++++++++++++++++++++++++++--------
> >  drivers/net/phy/phy_device.c | 21 +++++++++++++-
> >  include/linux/phy.h          |  6 ++++
> >  3 files changed, 68 insertions(+), 13 deletions(-)
> > 
> @Russel: I read your last reply to the v2 series as an ack here, am I
> correct?

Yes - I've just given two r-b's as well for the last two patches.
Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!