Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.

Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
V1 -> V2: Add the according vendor prefix
          Change the board string to enum
          Modify the board description
---
 .../devicetree/bindings/mips/loongson/devices.yaml   | 12 ++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml         |  2 ++
 2 files changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
index f13ce386f42c..15a43ce51bbf 100644
--- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
+++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
@@ -37,6 +37,18 @@ properties:
         items:
           - const: loongson,loongson64v-4core-virtio
 
+      - description: LS1B based boards
+        items:
+          - enum:
+              - loongson,lsgz-1b-dev
+          - const: loongson,ls1b
+
+      - description: LS1C based boards
+        items:
+          - enum:
+              - loongsonclub,smartloong-1c
+          - const: loongson,ls1c
+
 additionalProperties: true
 
 ...
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 0e57ae744199..47565ebae4d1 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -757,6 +757,8 @@ patternProperties:
     description: Lontium Semiconductor Corporation
   "^loongson,.*":
     description: Loongson Technology Corporation Limited
+  "^loongsonclub,.*":
+    description: Loongson Club
   "^lsi,.*":
     description: LSI Corp. (LSI Logic)
   "^lwn,.*":

base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8
-- 
2.34.1

On 21/02/2023 11:26, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V1 -> V2: Add the according vendor prefix
>           Change the board string to enum
>           Modify the board description

Thank you for your patch. There is something to discuss/improve.

> ---
>  .../devicetree/bindings/mips/loongson/devices.yaml   | 12 ++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml         |  2 ++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..15a43ce51bbf 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,18 @@ properties:
>          items:
>            - const: loongson,loongson64v-4core-virtio
>  
> +      - description: LS1B based boards
> +        items:
> +          - enum:
> +              - loongson,lsgz-1b-dev
> +          - const: loongson,ls1b
> +
> +      - description: LS1C based boards
> +        items:
> +          - enum:
> +              - loongsonclub,smartloong-1c
> +          - const: loongson,ls1c
> +
>  additionalProperties: true
>  
>  ...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 0e57ae744199..47565ebae4d1 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -757,6 +757,8 @@ patternProperties:
>      description: Lontium Semiconductor Corporation
>    "^loongson,.*":
>      description: Loongson Technology Corporation Limited
> +  "^loongsonclub,.*":
> +    description: Loongson Club

Are you sure that this is a board manufacturer?

Best regards,
Krzysztof

On Tue, Feb 21, 2023 at 6:36 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 21/02/2023 11:26, Keguang Zhang wrote:
> > Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
> >
> > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> > ---
> > V1 -> V2: Add the according vendor prefix
> >           Change the board string to enum
> >           Modify the board description
>
> Thank you for your patch. There is something to discuss/improve.
>
> > ---
> >  .../devicetree/bindings/mips/loongson/devices.yaml   | 12 ++++++++++++
> >  .../devicetree/bindings/vendor-prefixes.yaml         |  2 ++
> >  2 files changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > index f13ce386f42c..15a43ce51bbf 100644
> > --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > @@ -37,6 +37,18 @@ properties:
> >          items:
> >            - const: loongson,loongson64v-4core-virtio
> >
> > +      - description: LS1B based boards
> > +        items:
> > +          - enum:
> > +              - loongson,lsgz-1b-dev
> > +          - const: loongson,ls1b
> > +
> > +      - description: LS1C based boards
> > +        items:
> > +          - enum:
> > +              - loongsonclub,smartloong-1c
> > +          - const: loongson,ls1c
> > +
> >  additionalProperties: true
> >
> >  ...
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 0e57ae744199..47565ebae4d1 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -757,6 +757,8 @@ patternProperties:
> >      description: Lontium Semiconductor Corporation
> >    "^loongson,.*":
> >      description: Loongson Technology Corporation Limited
> > +  "^loongsonclub,.*":
> > +    description: Loongson Club
>
> Are you sure that this is a board manufacturer?
>
Sorry, that's inaccurate.
Let me update the manufacturer later.

> Best regards,
> Krzysztof
>


-- 
Best regards,

Kelvin Cheung