mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.
Take advantage of this to constify the structure definition to prevent
modification at runtime.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 13459c69095a..be710dc4dc3e 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = {
.store = slab_attr_store,
};
-static struct kobj_type slab_ktype = {
+static const struct kobj_type slab_ktype = {
.sysfs_ops = &slab_sysfs_ops,
.release = kmem_cache_release,
};
---
base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f
change-id: 20230220-kobj_type-mm-slub-02d25836de84
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
On 2/21/23 00:25, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at runtime. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Thanks, added to slab/for-6.4/trivial > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 13459c69095a..be710dc4dc3e 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = { > .store = slab_attr_store, > }; > > -static struct kobj_type slab_ktype = { > +static const struct kobj_type slab_ktype = { > .sysfs_ops = &slab_sysfs_ops, > .release = kmem_cache_release, > }; > > --- > base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f > change-id: 20230220-kobj_type-mm-slub-02d25836de84 > > Best regards,
On Mon, Feb 20, 2023 at 11:25:28PM +0000, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at runtime. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 13459c69095a..be710dc4dc3e 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = { > .store = slab_attr_store, > }; > > -static struct kobj_type slab_ktype = { > +static const struct kobj_type slab_ktype = { > .sysfs_ops = &slab_sysfs_ops, > .release = kmem_cache_release, > }; > > --- Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f > change-id: 20230220-kobj_type-mm-slub-02d25836de84 > > Best regards, > -- > Thomas Weißschuh <linux@weissschuh.net> >
© 2016 - 2025 Red Hat, Inc.