reset: ath79: Use devm_platform_get_and_ioremap_resource()

[PATCH] reset: ath79: Use devm_platform_get_and_ioremap_resource()

Posted by ye.xingchen@zte.com.cn 2 years, 6 months ago

From: Ye Xingchen <ye.xingchen@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/reset/reset-ath79.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/reset/reset-ath79.c b/drivers/reset/reset-ath79.c
index e48d8fcb3133..801a65db2e15 100644
--- a/drivers/reset/reset-ath79.c
+++ b/drivers/reset/reset-ath79.c
@@ -86,7 +86,6 @@ static int ath79_reset_restart_handler(struct notifier_block *nb,
 static int ath79_reset_probe(struct platform_device *pdev)
 {
 	struct ath79_reset *ath79_reset;
-	struct resource *res;
 	int err;

 	ath79_reset = devm_kzalloc(&pdev->dev,
@@ -96,8 +95,7 @@ static int ath79_reset_probe(struct platform_device *pdev)

 	platform_set_drvdata(pdev, ath79_reset);

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ath79_reset->base = devm_ioremap_resource(&pdev->dev, res);
+	ath79_reset->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(ath79_reset->base))
 		return PTR_ERR(ath79_reset->base);

-- 
2.25.1

Re: [PATCH] reset: ath79: Use devm_platform_get_and_ioremap_resource()

Posted by Philipp Zabel 2 years, 6 months ago

On Mi, 2023-02-15 at 17:05 +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> ---
>  drivers/reset/reset-ath79.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/reset-ath79.c b/drivers/reset/reset-ath79.c
> index e48d8fcb3133..801a65db2e15 100644
> --- a/drivers/reset/reset-ath79.c
> +++ b/drivers/reset/reset-ath79.c
> @@ -86,7 +86,6 @@ static int ath79_reset_restart_handler(struct notifier_block *nb,
>  static int ath79_reset_probe(struct platform_device *pdev)
>  {
>  	struct ath79_reset *ath79_reset;
> -	struct resource *res;
>  	int err;
> 
>  	ath79_reset = devm_kzalloc(&pdev->dev,
> @@ -96,8 +95,7 @@ static int ath79_reset_probe(struct platform_device *pdev)
> 
>  	platform_set_drvdata(pdev, ath79_reset);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ath79_reset->base = devm_ioremap_resource(&pdev->dev, res);
> +	ath79_reset->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);


Thank you for the patches. Since the resource not used, it seems to me
that devm_platform_ioremap_resource() would be a better fit.

regards
Philipp