[PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared

Lucas Tanure posted 1 patch 2 years, 6 months ago
There is a newer version of this series
include/sound/soc-dapm.h | 1 +
1 file changed, 1 insertion(+)
[PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
Posted by Lucas Tanure 2 years, 6 months ago
Add sound/pcm.h header to include struct snd_pcm_substream used in
snd_soc_dapm_update_dai function.

Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
 include/sound/soc-dapm.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index 77495e5988c1..8fbb50a11d80 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -14,6 +14,7 @@
 #include <sound/control.h>
 #include <sound/soc-topology.h>
 #include <sound/asoc.h>
+#include <sound/pcm.h>
 
 struct device;
 struct snd_soc_pcm_runtime;
-- 
2.39.1
Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
Posted by Mark Brown 2 years, 6 months ago
On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.

> +#include <sound/pcm.h>
>  
>  struct device;
>  struct snd_soc_pcm_runtime;

This should be a forward declaration of the struct like the
adjacent forward declarations that are already there, we only
pass a pointer to it we don't need the contents.
Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
Posted by Charles Keepax 2 years, 6 months ago
On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
> 
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
Posted by AngeloGioacchino Del Regno 2 years, 6 months ago
Il 15/02/23 10:46, Lucas Tanure ha scritto:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
> 
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>