[v2] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

[PATCH v2] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

Posted by Konrad Dybcio 2 years, 6 months ago

In the commit mentioned in the fixes tag, everything went well except
the fallback and the specific compatible got swapped and the 8998 DTSI
began failing the dtbs check. Fix it.

Fixes: f86fe08ef00f ("dt-bindings: PCI: qcom: Add MSM8998 specific compatible")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 - > v2:

- Use the correct commit in fixes

 Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 872817d6d2bd..fb32c43dd12d 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -39,8 +39,8 @@ properties:
           - qcom,pcie-sm8450-pcie0
           - qcom,pcie-sm8450-pcie1
       - items:
-          - const: qcom,pcie-msm8996
           - const: qcom,pcie-msm8998
+          - const: qcom,pcie-msm8996
 
   reg:
     minItems: 4
-- 
2.39.1

Re: [PATCH v2] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

Posted by Rob Herring 2 years, 6 months ago

On Tue, 14 Feb 2023 10:12:02 +0100, Konrad Dybcio wrote:
> In the commit mentioned in the fixes tag, everything went well except
> the fallback and the specific compatible got swapped and the 8998 DTSI
> began failing the dtbs check. Fix it.
> 
> Fixes: f86fe08ef00f ("dt-bindings: PCI: qcom: Add MSM8998 specific compatible")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> v1 - > v2:
> 
> - Use the correct commit in fixes
> 
>  Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

Posted by Krzysztof Kozlowski 2 years, 6 months ago

On 14/02/2023 10:12, Konrad Dybcio wrote:
> In the commit mentioned in the fixes tag, everything went well except
> the fallback and the specific compatible got swapped and the 8998 DTSI
> began failing the dtbs check. Fix it.
> 
> Fixes: f86fe08ef00f ("dt-bindings: PCI: qcom: Add MSM8998 specific compatible")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---

[bhelgaas: sort msm8996 before msm8998]
yes... I love amends by maintainers.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof