[v3] octeon_ep: deferred probe and mailbox

[PATCH net-next v3 5/7] octeon_ep: support asynchronous notifications

Posted by Veerasenareddy Burru 2 years, 6 months ago

Add asynchronous notification support to the control mailbox.

Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
---
v2 -> v3:
 * no change

v1 -> v2:
 * no change

 .../marvell/octeon_ep/octep_ctrl_net.c        | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
index 715af1891d0d..80bcd6cd4732 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
@@ -279,6 +279,33 @@ static int process_mbox_resp(struct octep_device *oct,
 	return 0;
 }
 
+static int process_mbox_notify(struct octep_device *oct,
+			       struct octep_ctrl_mbox_msg *msg)
+{
+	struct octep_ctrl_net_f2h_req *req;
+	struct net_device *netdev = oct->netdev;
+
+	req = (struct octep_ctrl_net_f2h_req *)msg->sg_list[0].msg;
+	switch (req->hdr.s.cmd) {
+	case OCTEP_CTRL_NET_F2H_CMD_LINK_STATUS:
+		if (netif_running(netdev)) {
+			if (req->link.state) {
+				dev_info(&oct->pdev->dev, "netif_carrier_on\n");
+				netif_carrier_on(netdev);
+			} else {
+				dev_info(&oct->pdev->dev, "netif_carrier_off\n");
+				netif_carrier_off(netdev);
+			}
+		}
+		break;
+	default:
+		pr_info("Unknown mbox req : %u\n", req->hdr.s.cmd);
+		break;
+	}
+
+	return 0;
+}
+
 int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)
 {
 	static u16 msg_sz = sizeof(union octep_ctrl_net_max_data);
@@ -303,6 +330,8 @@ int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)
 			process_mbox_req(oct, &msg);
 		else if (msg.hdr.s.flags & OCTEP_CTRL_MBOX_MSG_HDR_FLAG_RESP)
 			process_mbox_resp(oct, &msg);
+		else if (msg.hdr.s.flags & OCTEP_CTRL_MBOX_MSG_HDR_FLAG_NOTIFY)
+			process_mbox_notify(oct, &msg);
 	}
 
 	return 0;
-- 
2.36.0

Re: [PATCH net-next v3 5/7] octeon_ep: support asynchronous notifications

Posted by Maciej Fijalkowski 2 years, 6 months ago

On Mon, Feb 13, 2023 at 09:14:20PM -0800, Veerasenareddy Burru wrote:
> Add asynchronous notification support to the control mailbox.
> 
> Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> ---
> v2 -> v3:
>  * no change
> 
> v1 -> v2:
>  * no change
> 
>  .../marvell/octeon_ep/octep_ctrl_net.c        | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> index 715af1891d0d..80bcd6cd4732 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> @@ -279,6 +279,33 @@ static int process_mbox_resp(struct octep_device *oct,
>  	return 0;
>  }
>  
> +static int process_mbox_notify(struct octep_device *oct,

void

> +			       struct octep_ctrl_mbox_msg *msg)
> +{
> +	struct octep_ctrl_net_f2h_req *req;
> +	struct net_device *netdev = oct->netdev;

RCT

> +
> +	req = (struct octep_ctrl_net_f2h_req *)msg->sg_list[0].msg;
> +	switch (req->hdr.s.cmd) {
> +	case OCTEP_CTRL_NET_F2H_CMD_LINK_STATUS:
> +		if (netif_running(netdev)) {
> +			if (req->link.state) {
> +				dev_info(&oct->pdev->dev, "netif_carrier_on\n");
> +				netif_carrier_on(netdev);
> +			} else {
> +				dev_info(&oct->pdev->dev, "netif_carrier_off\n");
> +				netif_carrier_off(netdev);
> +			}
> +		}
> +		break;
> +	default:
> +		pr_info("Unknown mbox req : %u\n", req->hdr.s.cmd);
> +		break;
> +	}
> +
> +	return 0;
> +}
> +
>  int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)
>  {
>  	static u16 msg_sz = sizeof(union octep_ctrl_net_max_data);
> @@ -303,6 +330,8 @@ int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)
>  			process_mbox_req(oct, &msg);
>  		else if (msg.hdr.s.flags & OCTEP_CTRL_MBOX_MSG_HDR_FLAG_RESP)
>  			process_mbox_resp(oct, &msg);
> +		else if (msg.hdr.s.flags & OCTEP_CTRL_MBOX_MSG_HDR_FLAG_NOTIFY)
> +			process_mbox_notify(oct, &msg);
>  	}
>  
>  	return 0;
> -- 
> 2.36.0
>

RE: [EXT] Re: [PATCH net-next v3 5/7] octeon_ep: support asynchronous notifications

Posted by Veerasenareddy Burru 2 years, 5 months ago


> -----Original Message-----
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Sent: Wednesday, February 15, 2023 8:36 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Abhijit Ayarekar
> <aayarekar@marvell.com>; Sathesh B Edara <sedara@marvell.com>;
> Satananda Burla <sburla@marvell.com>; linux-doc@vger.kernel.org; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next v3 5/7] octeon_ep: support
> asynchronous notifications
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Mon, Feb 13, 2023 at 09:14:20PM -0800, Veerasenareddy Burru wrote:
> > Add asynchronous notification support to the control mailbox.
> >
> > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> > ---
> > v2 -> v3:
> >  * no change
> >
> > v1 -> v2:
> >  * no change
> >
> >  .../marvell/octeon_ep/octep_ctrl_net.c        | 29 +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > index 715af1891d0d..80bcd6cd4732 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > @@ -279,6 +279,33 @@ static int process_mbox_resp(struct octep_device
> *oct,
> >  	return 0;
> >  }
> >
> > +static int process_mbox_notify(struct octep_device *oct,
> 
> void
> 

Will change in next revision.

> > +			       struct octep_ctrl_mbox_msg *msg) {
> > +	struct octep_ctrl_net_f2h_req *req;
> > +	struct net_device *netdev = oct->netdev;
> 
> RCT
> 

Will fix in next revision. I missed some RCT violations in this patchset. Will take care for future submissions.
Thank you for kind review.

> > +
> > +	req = (struct octep_ctrl_net_f2h_req *)msg->sg_list[0].msg;
> > +	switch (req->hdr.s.cmd) {
> > +	case OCTEP_CTRL_NET_F2H_CMD_LINK_STATUS:
> > +		if (netif_running(netdev)) {
> > +			if (req->link.state) {
> > +				dev_info(&oct->pdev->dev,
> "netif_carrier_on\n");
> > +				netif_carrier_on(netdev);
> > +			} else {
> > +				dev_info(&oct->pdev->dev,
> "netif_carrier_off\n");
> > +				netif_carrier_off(netdev);
> > +			}
> > +		}
> > +		break;
> > +	default:
> > +		pr_info("Unknown mbox req : %u\n", req->hdr.s.cmd);
> > +		break;
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> >  int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)  {
> >  	static u16 msg_sz = sizeof(union octep_ctrl_net_max_data); @@ -
> 303,6
> > +330,8 @@ int octep_ctrl_net_recv_fw_messages(struct octep_device
> *oct)
> >  			process_mbox_req(oct, &msg);
> >  		else if (msg.hdr.s.flags &
> OCTEP_CTRL_MBOX_MSG_HDR_FLAG_RESP)
> >  			process_mbox_resp(oct, &msg);
> > +		else if (msg.hdr.s.flags &
> OCTEP_CTRL_MBOX_MSG_HDR_FLAG_NOTIFY)
> > +			process_mbox_notify(oct, &msg);
> >  	}
> >
> >  	return 0;
> > --
> > 2.36.0
> >

[PATCH net-next v3 1/7] octeon_ep: defer probe if firmware not ready
[PATCH net-next v3 2/7] octeon_ep: poll for control messages
[PATCH net-next v3 3/7] octeon_ep: control mailbox for multiple PFs
[PATCH net-next v3 4/7] octeon_ep: enhance control mailbox for VF support
[PATCH net-next v3 5/7] octeon_ep: support asynchronous notifications
[PATCH net-next v3 6/7] octeon_ep: control mbox support for VF stats and link info
[PATCH net-next v3 7/7] octeon_ep: add heartbeat monitor