md: make kobj_type structures constant

[PATCH] md: make kobj_type structures constant

Posted by Thomas Weißschuh 2 years, 6 months ago

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definitions to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/md/md.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 02b0240e7c71..091c1d6f0b87 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -78,7 +78,7 @@
 static LIST_HEAD(pers_list);
 static DEFINE_SPINLOCK(pers_lock);
 
-static struct kobj_type md_ktype;
+static const struct kobj_type md_ktype;
 
 struct md_cluster_operations *md_cluster_ops;
 EXPORT_SYMBOL(md_cluster_ops);
@@ -3600,7 +3600,7 @@ static const struct sysfs_ops rdev_sysfs_ops = {
 	.show		= rdev_attr_show,
 	.store		= rdev_attr_store,
 };
-static struct kobj_type rdev_ktype = {
+static const struct kobj_type rdev_ktype = {
 	.release	= rdev_free,
 	.sysfs_ops	= &rdev_sysfs_ops,
 	.default_groups	= rdev_default_groups,
@@ -5558,7 +5558,7 @@ static const struct sysfs_ops md_sysfs_ops = {
 	.show	= md_attr_show,
 	.store	= md_attr_store,
 };
-static struct kobj_type md_ktype = {
+static const struct kobj_type md_ktype = {
 	.release	= md_kobj_release,
 	.sysfs_ops	= &md_sysfs_ops,
 	.default_groups	= md_attr_groups,

---
base-commit: f6feea56f66d34259c4222fa02e8171c4f2673d1
change-id: 20230214-kobj_type-md-a3c7773574cf

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

Re: [PATCH] md: make kobj_type structures constant

Posted by Song Liu 2 years, 6 months ago

On Mon, Feb 13, 2023 at 7:19 PM Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Applied to md-next. Thanks!

Song

> ---
>  drivers/md/md.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 02b0240e7c71..091c1d6f0b87 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -78,7 +78,7 @@
>  static LIST_HEAD(pers_list);
>  static DEFINE_SPINLOCK(pers_lock);
>
> -static struct kobj_type md_ktype;
> +static const struct kobj_type md_ktype;
>
>  struct md_cluster_operations *md_cluster_ops;
>  EXPORT_SYMBOL(md_cluster_ops);
> @@ -3600,7 +3600,7 @@ static const struct sysfs_ops rdev_sysfs_ops = {
>         .show           = rdev_attr_show,
>         .store          = rdev_attr_store,
>  };
> -static struct kobj_type rdev_ktype = {
> +static const struct kobj_type rdev_ktype = {
>         .release        = rdev_free,
>         .sysfs_ops      = &rdev_sysfs_ops,
>         .default_groups = rdev_default_groups,
> @@ -5558,7 +5558,7 @@ static const struct sysfs_ops md_sysfs_ops = {
>         .show   = md_attr_show,
>         .store  = md_attr_store,
>  };
> -static struct kobj_type md_ktype = {
> +static const struct kobj_type md_ktype = {
>         .release        = md_kobj_release,
>         .sysfs_ops      = &md_sysfs_ops,
>         .default_groups = md_attr_groups,
>
> ---
> base-commit: f6feea56f66d34259c4222fa02e8171c4f2673d1
> change-id: 20230214-kobj_type-md-a3c7773574cf
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>