[v1] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

[PATCH] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

Konrad Dybcio posted 1 patch 2 years, 7 months ago

Diff against v2
Download mbox

There is a newer version of this series

Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

Posted by Konrad Dybcio 2 years, 7 months ago

In the commit mentioned in the fixes tag, everything went well except
the fallback and the specific compatible got swapped and the 8998 DTSI
began failing the dtbs check. Fix it.

Fixes: 7d1780d023ca ("dt-bindings: PCI: qcom: Unify MSM8996 and MSM8998 clock order")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 872817d6d2bd..fb32c43dd12d 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -39,8 +39,8 @@ properties:
           - qcom,pcie-sm8450-pcie0
           - qcom,pcie-sm8450-pcie1
       - items:
-          - const: qcom,pcie-msm8996
           - const: qcom,pcie-msm8998
+          - const: qcom,pcie-msm8996
 
   reg:
     minItems: 4
-- 
2.39.1

Re: [PATCH] dt-bindings: PCI: qcom: Fix msm8998-specific compatible

Posted by Krzysztof Kozlowski 2 years, 6 months ago

On 13/02/2023 22:14, Konrad Dybcio wrote:
> In the commit mentioned in the fixes tag, everything went well except
> the fallback and the specific compatible got swapped and the 8998 DTSI
> began failing the dtbs check. Fix it.
> 
> Fixes: 7d1780d023ca ("dt-bindings: PCI: qcom: Unify MSM8996 and MSM8998 clock order")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

I don't see compatibles being touched at all in this commit. This is not
correct commit to fix.

Best regards,
Krzysztof