1. Patchew
  2. linux
  3. [PATCH v2 0/4] watchdog: mt7621-wdt: avoid globals and arch dependencies
  4. View patch

[PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers

Sergio Paracuellos posted 4 patches 2 years, 12 months ago
There is a newer version of this series
[PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
Posted by Sergio Paracuellos 2 years, 12 months ago 
MT7621 SoC provides a system controller node for accessing to some registers.
Add a phandle in this node to avoid using MIPS related arch operations and
includes in watchdog driver code.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
index b2b17fdf4..cc701e920 100644
--- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
@@ -19,6 +19,12 @@ properties:
   reg:
     maxItems: 1
 
+  ralink,sysctl:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      phandle to system controller 'sysc' syscon node which
+      controls system registers
+
 required:
   - compatible
   - reg
@@ -30,4 +36,5 @@ examples:
     watchdog@100 {
       compatible = "mediatek,mt7621-wdt";
       reg = <0x100 0x100>;
+      ralink,sysctl = <&sysc>;
     };
-- 
2.25.1
Re: [PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
Posted by Krzysztof Kozlowski 2 years, 12 months ago 
On 10/02/2023 13:17, Sergio Paracuellos wrote:
> MT7621 SoC provides a system controller node for accessing to some registers.
> Add a phandle in this node to avoid using MIPS related arch operations and
> includes in watchdog driver code.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> index b2b17fdf4..cc701e920 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> @@ -19,6 +19,12 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  ralink,sysctl:

Thanks for the changes. I did not notice it before - isn't Ralink part
of Mediatek now? Also compatible is mediatek, not "ralink"?



Best regards,
Krzysztof
Re: [PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
Posted by Sergio Paracuellos 2 years, 12 months ago 
On Fri, Feb 10, 2023 at 2:03 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/02/2023 13:17, Sergio Paracuellos wrote:
> > MT7621 SoC provides a system controller node for accessing to some registers.
> > Add a phandle in this node to avoid using MIPS related arch operations and
> > includes in watchdog driver code.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> >  .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> > index b2b17fdf4..cc701e920 100644
> > --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> > @@ -19,6 +19,12 @@ properties:
> >    reg:
> >      maxItems: 1
> >
> > +  ralink,sysctl:
>
> Thanks for the changes. I did not notice it before - isn't Ralink part
> of Mediatek now? Also compatible is mediatek, not "ralink"?

Yes, it is. I was using the same prefix as for the memory controller
syscon phandler inside the 'sysc' node [0].

I have no problems at all in changing this to 'mediatek' if preferred.

Thanks,
    Sergio Paracuellos

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/ralink/mt7621.dtsi#n67
>
>
>
> Best regards,
> Krzysztof
>
Re: [PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
Posted by Krzysztof Kozlowski 2 years, 12 months ago 
On 10/02/2023 14:14, Sergio Paracuellos wrote:
> On Fri, Feb 10, 2023 at 2:03 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 10/02/2023 13:17, Sergio Paracuellos wrote:
>>> MT7621 SoC provides a system controller node for accessing to some registers.
>>> Add a phandle in this node to avoid using MIPS related arch operations and
>>> includes in watchdog driver code.
>>>
>>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>>> ---
>>>  .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
>>> index b2b17fdf4..cc701e920 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
>>> @@ -19,6 +19,12 @@ properties:
>>>    reg:
>>>      maxItems: 1
>>>
>>> +  ralink,sysctl:
>>
>> Thanks for the changes. I did not notice it before - isn't Ralink part
>> of Mediatek now? Also compatible is mediatek, not "ralink"?
> 
> Yes, it is. I was using the same prefix as for the memory controller
> syscon phandler inside the 'sysc' node [0].
> 
> I have no problems at all in changing this to 'mediatek' if preferred.
> 

Yes, mediatek as already used in this binding is preferred.

Best regards,
Krzysztof
Re: [PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers
Posted by Sergio Paracuellos 2 years, 12 months ago 
On Fri, Feb 10, 2023 at 2:35 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/02/2023 14:14, Sergio Paracuellos wrote:
> > On Fri, Feb 10, 2023 at 2:03 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 10/02/2023 13:17, Sergio Paracuellos wrote:
> >>> MT7621 SoC provides a system controller node for accessing to some registers.
> >>> Add a phandle in this node to avoid using MIPS related arch operations and
> >>> includes in watchdog driver code.
> >>>
> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >>> ---
> >>>  .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
> >>>  1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> >>> index b2b17fdf4..cc701e920 100644
> >>> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> >>> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> >>> @@ -19,6 +19,12 @@ properties:
> >>>    reg:
> >>>      maxItems: 1
> >>>
> >>> +  ralink,sysctl:
> >>
> >> Thanks for the changes. I did not notice it before - isn't Ralink part
> >> of Mediatek now? Also compatible is mediatek, not "ralink"?
> >
> > Yes, it is. I was using the same prefix as for the memory controller
> > syscon phandler inside the 'sysc' node [0].
> >
> > I have no problems at all in changing this to 'mediatek' if preferred.
> >
>
> Yes, mediatek as already used in this binding is preferred.

Sure, I will do it and send v3. Let's wait for some other review
comments in the rest of the patches and will send all them together.

>
> Best regards,
> Krzysztof
>

Thanks,
    Sergio Paracuellos

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.